pijul: 1.0.0-alpha.24 -> 1.0.0-alpha.31 #108506
Conversation
ofborg
bot
added
11.by: package-maintainer
|
/marvin opt-in |
|
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here. |
marvin-mk2
bot
added
marvin
| @@ -1,26 +1,28 @@ | |||
| { stdenv | |||
| , darwin | |||
There was a problem hiding this comment.
Please do not use darwin as an input directly.
There was a problem hiding this comment.
Should I import pkgs then? I am not sure what to do here.
There was a problem hiding this comment.
The alternative from greping nixpkgs seems to be to import pkgs and substitute darwin for pkgs.darwin.
There was a problem hiding this comment.
That is even worse. Please do something like
a = callPackages ../ {
inherit (darwin.apple_sdk.frameworks) Security;
};
in top-level.
There was a problem hiding this comment.
Oh ok, yeah that seems better.
| }: | ||
|
|
||
| assert gitImportSupport -> libgit2 != null; |
There was a problem hiding this comment.
| assert gitImportSupport -> libgit2 != null; |
| , gitImportSupport ? true | ||
| , libgit2 ? null | ||
| # Optionals | ||
| , gitImportSupport ? true, libgit2 ? null |
There was a problem hiding this comment.
| , gitImportSupport ? true, libgit2 ? null | |
| , gitImportSupport ? true, libgit2 |
marvin-mk2
bot
added
awaiting_reviewer
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package built:
|
|
Close due to another PR updating this package: #108767 |
Motivation for this change
There have been several fixes to issues and the patch format was changed a bit.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)