Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/chrony: add support for Network Time Security (NTS) authentication #108578

Merged
merged 4 commits into from Jan 22, 2021
Merged

nixos/chrony: add support for Network Time Security (NTS) authentication #108578

merged 4 commits into from Jan 22, 2021

Conversation

ctem
Copy link
Contributor

@ctem ctem commented Jan 6, 2021

Motivation for this change

NTS authentication support was the headline enhancement of the chrony-4.0 release. This PR adds the enableNTS option to enable use of this support.

To make this module a bit more convenient to use, this PR also adds the following options: serverOption, directory, and package. Defaults remain unchanged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

bbigras
bbigras approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@bbigras bbigras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds and runs fine. thanks!! 👍

aanderse
aanderse reviewed Jan 6, 2021
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nixos/modules/services/networking/ntp/chrony.nix Show resolved Hide resolved
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/334

@AndersonTorres AndersonTorres merged commit 0f31f03 into NixOS:master Jan 22, 2021
@bbigras
Copy link
Contributor

bbigras commented Jan 22, 2021

Thanks!

@ctem ctem deleted the feature/chrony branch January 25, 2021 11:20
@ctem
Copy link
Contributor Author

ctem commented Jan 25, 2021

Thank you everyone! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse left review comments

@bbigras bbigras bbigras approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice thoughtpolice is a code owner

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ctem @nixos-discourse @bbigras @aanderse @AndersonTorres