Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nextcloud: improve documentation on defaults #108519

Merged
merged 1 commit into from Jan 7, 2021
Merged

nextcloud: improve documentation on defaults #108519

merged 1 commit into from Jan 7, 2021

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 5, 2021

Motivation for this change
  • It should be made explicit in the eval-error that the CVE only affects
    a component which is turned off by default.
  • For more clarity, the default version used by the module is noted in
    the manual.

Closes #108419

cc @madonius

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
nextcloud: improve documentation on defaults
78f022e 
* It should be made explicit in the eval-error that the CVE only affects
  a component which is turned off by default.
* For more clarity, the default version used by the module is noted in
  the manual.

Closes NixOS#108419
@Ma27 Ma27 mentioned this pull request Jan 5, 2021
Merged
10 tasks
@ajs124
Copy link
Member

ajs124 commented Jan 5, 2021

It might also be worth noting that they won't be fixed in 19.x, from my understanding. So upgrading to a newer major release is the only solution.

@Ma27 Ma27 merged commit 1f7cbcc into NixOS:master Jan 7, 2021
@Ma27 Ma27 deleted the nextcloud-docs branch January 7, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@nlewo nlewo nlewo approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update default to Nextcloud 20
4 participants
@Ma27 @ajs124 @mweinelt @nlewo