Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitAndTools.delta: 0.5.0 -> 0.5.1 #108509

Merged
merged 1 commit into from Jan 6, 2021
Merged

gitAndTools.delta: 0.5.0 -> 0.5.1 #108509

merged 1 commit into from Jan 6, 2021

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jan 5, 2021

https://github.com/dandavison/delta/releases/tag/0.5.1

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108509 run on x86_64-linux 1

2 packages built:
  • bat-extras.batdiff
  • gitAndTools.delta

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108509 run on x86_64-darwin 1

2 packages failed to build and are new build failures:

We should report this upstream/disable tests for darwin.

@marsam marsam merged commit a3ab47e into NixOS:master Jan 6, 2021
@zowoq zowoq deleted the delta branch January 6, 2021 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants