Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix-update: 0.3 -> 0.3.1 #108508

Merged
merged 1 commit into from Jan 6, 2021
Merged

nix-update: 0.3 -> 0.3.1 #108508

merged 1 commit into from Jan 6, 2021

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jan 5, 2021

https://github.com/Mic92/nix-update/releases/tag/0.3.1

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thiagokokada
Copy link
Contributor

thiagokokada commented Jan 5, 2021

Result of nixpkgs-review pr 108508 run on x86_64-linux 1

1 package built:
  • nix-update

Tested with nix update fzf:

[nix-shell:~/.cache/nixpkgs-review/pr-108508/nixpkgs]$ nix-update fzf
$ nix eval --json --impure --experimental-features nix-command --expr (with import ./. {};
    let
      pkg = fzf;
      raw_version_position = builtins.unsafeGetAttrPos "version" pkg;

      position = if pkg ? isRubyGem then
        raw_version_position
      else
        builtins.unsafeGetAttrPos "src" pkg;
    in {
      name = pkg.name;
      old_version = (builtins.parseDrvName pkg.name).version;
      inherit raw_version_position;
      filename = position.file;
      line = position.line;
      urls = pkg.src.urls or null;
      url = pkg.src.url or null;
      rev = pkg.src.url.rev or null;
      hash = pkg.src.outputHash;
      mod_sha256 = pkg.modSha256 or null;
      vendor_sha256 = pkg.vendorSha256 or null;
      cargo_sha256 = pkg.cargoSha256 or null;
      tests = pkg.passthru.tests or null;
    })
fetch https://github.com/junegunn/fzf/releases.atom
Update 0.24.4 -> 0.25.0 in /home/thiagoko/.cache/nixpkgs-review/pr-108508/nixpkgs/pkgs/tools/misc/fzf/default.nix
$ nix-prefetch (import ./. {}).fzf
warning: ignoring the user-specified setting 'allow-unsafe-native-code-during-evaluation', because it is a restricted setting and you are not a trusted user
The package fzf-0.25.0 will be fetched as follows:
> fetchFromGitHub {
>   owner = "junegunn";
>   repo = "fzf";
>   rev = "0.25.0";
>   sha256 = "17k32wr70sp7ag69xww2q9mrgnzakgkjw6la04n3jlhfa5z37dzj";
> }

$ nix-prefetch { sha256 }: (import ./. {}).fzf.go-modules.overrideAttrs (_: { vendorSha256 = sha256; })
warning: ignoring the user-specified setting 'allow-unsafe-native-code-during-evaluation', because it is a restricted setting and you are not a trusted user
The fetcher will be called as follows:
> <unnamed> {
>   sha256 = "0000000000000000000000000000000000000000000000000000";
> }

@SuperSandro2000 SuperSandro2000 merged commit 91f3a87 into NixOS:master Jan 6, 2021
@zowoq zowoq deleted the nix-update branch January 6, 2021 02:08
@Mic92
Copy link
Member

Mic92 commented Jan 6, 2021

I should add a github action to open PRs like this automatically using nix-update.

@thiagokokada
Copy link
Contributor

Well, there is already @r-ryantm bot for this, wouldn't they possible conflict 🤔 ?

@Mic92
Copy link
Member

Mic92 commented Jan 6, 2021

Well, there is already @r-ryantm bot for this, wouldn't they possible conflict thinking ?

Well this one I would only put in my nix-update ci. it won't update other packages but nix-update.

@thiagokokada
Copy link
Contributor

thiagokokada commented Jan 6, 2021

Well, there is already @r-ryantm bot for this, wouldn't they possible conflict thinking ?

Well this one I would only put in my nix-update ci. it won't update other packages but nix-update.

Huh, makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants