Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dasel: 1.12.0 -> 1.12.2 #108527

Merged
merged 2 commits into from Jan 7, 2021
Merged

dasel: 1.12.0 -> 1.12.2 #108527

merged 2 commits into from Jan 7, 2021

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Jan 5, 2021

Motivation for this change

Upgrade to 1.12.2.

dasel: 1.12.1 -> 1.12.2

Fixed:

  • Fix a bug that stopped the write parser being properly detected when writing to the input file.

dasel: 1.12.0 -> 1.12.1
Changed:

  • Build workflows now updated to run on ubuntu-latest and use a matrix to build assets for linux, darwin and windows for both amd64 and 386.

Fixed:

  • Release asset for macos/darwin is now named dasel_darwin_amd64 instead of dasel_macos_amd64.
  • Self-updater now identifies dev version as development.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Changed:
- Build workflows now updated to run on ubuntu-latest and use a matrix to build assets for linux, darwin and windows for both amd64 and 386.

Fixed:
- Release asset for macos/darwin is now named dasel_darwin_amd64 instead of dasel_macos_amd64.
- Self-updater now identifies dev version as development.
Fixed:
- Fix a bug that stopped the write parser being properly detected when writing to the input file.
@0x4A6F 0x4A6F changed the title dasel: 1.12.0 -> 1.12.1 dasel: 1.12.0 -> 1.12.2 Jan 6, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108527 run on x86_64-linux 1

1 package built:
  • dasel

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108527 run on x86_64-darwin 1

1 package built:
  • dasel

@SuperSandro2000 SuperSandro2000 merged commit 00525bf into NixOS:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants