Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dockerTools: Don't apologize #108581

Merged
merged 1 commit into from Jan 8, 2021
Merged

dockerTools: Don't apologize #108581

merged 1 commit into from Jan 8, 2021

Conversation

roberth
Copy link
Member

@roberth roberth commented Jan 6, 2021

Motivation for this change

Warning about future breaking changes is wrong.

  • It suggests that the maintainers don't value backwards compatibility.
    They do.
  • It implies that other parts of Nixpkgs won't ever break. They will.
  • It implies that a well-defined "public" interface exists in Nixpkgs. It doesn't.
  • If the reasons above didn't apply, it should have been in the manual
    instead.

Breaking changes will come, especially to the interface. That can be the
only way we can make progress without breaking the image contents.

I don't think dockerTools is any different from most of Nixpkgs in
these regards.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@roberth
dockerTools: Don't apologize
a31607f 
Warning about future breaking changes is wrong.

 - It suggests that the maintainers don't value backwards compatibility.
   They do.
 - It implies that other parts of Nixpkgs won't ever break. They will.
 - It implies that a well-defined "public" interface exists. It doesn't.
 - If the reasons above didn't apply, it should have been in the manual
   instead.

Breaking changes will come, especially to the interface. That can be the
only way we can make progress without breaking the image _contents_.

I don't think dockerTools is any different from most of Nixpkgs in
these regards.
@danieldk danieldk merged commit 464633d into NixOS:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roberth @danieldk