Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.public.json: configure systemd topic label #545

Merged
merged 1 commit into from Jan 25, 2021

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Jan 6, 2021

I’ve used nixos/modules/system/boot/systemd to capture e.g. systemd.nix, systemd-unit-options.nix, etc. This should work as PathTagger just does a substring match, but I’m not sure if that’s something you’d like to depend on? If so, we’d have to move all the systemd options into a directory of their own (which might not be a bad thing anyway), or list them all out explicitly.

Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to rely on the substring. That said, do we want to add any of the tests to the list of monitored files?

config.public.json Outdated Show resolved Hide resolved
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

EDIT: Waiting on Graham to fix our deployment stuff before merging (so I don't forget to deploy this afterwards).

@cole-h cole-h merged commit 8026cc4 into NixOS:released Jan 25, 2021
@cole-h
Copy link
Member

cole-h commented Jan 25, 2021

A bit late, but everything's all good now. Thanks!

@alyssais alyssais deleted the systemd branch April 18, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants