Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crystal/make-package: enable parallel builds #108539

Merged
merged 1 commit into from May 22, 2022
Merged

crystal/make-package: enable parallel builds #108539

merged 1 commit into from May 22, 2022

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 6, 2021 •
edited

Motivation for this change

Allow for crystal builds to use more than 1 core.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
https://github.com/NixOS/nixpkgs/pull/108539

4 packages failed to build:
icr mint oq scry

6 packages built:
ameba crystal2nix gitAndTools.thicket lucky-cli shards shards_0_11

@jonringer jonringer requested a review from manveru January 6, 2021 01:47
@jonringer
Copy link
Contributor Author

broken packages are broken on master

@stale
Copy link

stale bot commented Jul 8, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 8, 2021
@siraben
Copy link
Member

siraben commented Jan 7, 2022

Any updates?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 7, 2022
@Artturin Artturin self-assigned this May 10, 2022
@siraben
Copy link
Member

siraben commented May 22, 2022

Result of nixpkgs-review pr 108539 run on aarch64-darwin 1

1 package marked as broken and skipped:
  • invidious
9 packages built:
  • ameba
  • crystal2nix
  • icr
  • kakoune-cr
  • lucky-cli
  • oq
  • scry
  • shards (shards_0_17)
  • thicket

@siraben siraben merged commit 26d8941 into NixOS:master May 22, 2022
@siraben
Copy link
Member

siraben commented May 22, 2022

Result of nixpkgs-review pr 108539 run on x86_64-darwin 1

11 packages failed to build:
  • ameba
  • crystal2nix
  • icr
  • invidious
  • kakoune-cr
  • lucky-cli
  • mint
  • oq
  • scry
  • shards (shards_0_17)
  • thicket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@manveru manveru Awaiting requested review from manveru

Assignees

@Artturin Artturin

Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonringer @siraben @SuperSandro2000 @Artturin