Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsurvive: init at 0.3 #108490

Merged
merged 1 commit into from Jan 6, 2021
Merged

libsurvive: init at 0.3 #108490

merged 1 commit into from Jan 6, 2021

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Jan 5, 2021 •
edited

Motivation for this change
  • driver package for tracking Valve VR headsets
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108490 run on x86_64-linux 1

1 package built:
  • libsurvive

@SuperSandro2000 SuperSandro2000 merged commit 59c03dc into NixOS:master Jan 6, 2021
@prusnak prusnak deleted the libsurvive branch January 6, 2021 07:59
@expipiplus1
Copy link
Contributor

There was already a PR open for this here: #107001 :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @SuperSandro2000 @expipiplus1