ocamlPackages.cstruct: 5.0.0 -> 6.0.0 #108492
Merged
+43
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sternenseemann
force-pushed
the
cstruct-6.0.0
branch
from
4eea729 to
51909cd
Compare
|
Build failures are due to #96090. Result of 2 packages failed to build:
136 packages built:
|
sternenseemann
force-pushed
the
cstruct-6.0.0
branch
from
51909cd to
8fe5023
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
and removed
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
labels
sternenseemann
force-pushed
the
cstruct-6.0.0
branch
from
8fe5023 to
99da308
Compare
sternenseemann
force-pushed
the
cstruct-6.0.0
branch
from
99da308 to
f28ed12
Compare
sternenseemann
force-pushed
the
cstruct-6.0.0
branch
from
f28ed12 to
2993210
Compare
vbgl
reviewed
Jan 31, 2021
sternenseemann
force-pushed
the
cstruct-6.0.0
branch
from
2993210 to
a2cd01b
Compare
vbgl
requested changes
Jan 31, 2021
|
|
Why is this in a separate PR? Isn’t it related to the update of cstruct/ppx_cstruct? |
sternenseemann
force-pushed
the
cstruct-6.0.0
branch
from
a2cd01b to
8622a79
Compare
|
Yeah, just didn't realize it was related! Added it here as well. |
|
Result of 121 packages built:
|
vbgl
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://github.com/mirage/ocaml-cstruct/releases/tag/v6.0.0, switch to ppxlib.
This PR also contains commits from #108137 (which made this upgrade possible) and should probably reviewed after the mentioned PR has been merged. For now this is for informational purposes mostly.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)