Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.sortedcollections: 1.2.1 -> 1.2.3 #108572

Merged
merged 4 commits into from Jan 11, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 6, 2021

Motivation for this change

Update to latest upstream release 1.2.3

Commit log: https://github.com/grantjenks/python-sortedcollections/commits/master

attrs is at 20.3.0 and this leads to build failures.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff fabaff changed the title Bump sortedcollections python3Packages.sortedcollections: 1.2.1 -> 1.2.3 Jan 6, 2021
@ofborg ofborg bot requested a review from jbaum98 January 6, 2021 10:28
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108572 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • python39Packages.google-music
2 packages failed to build and are new build failures:
  • python39Packages.flask-socketio: log was empty
  • python39Packages.python-socketio: log was empty
27 packages built:
  • appdaemon
  • gdbgui
  • google-music-scripts
  • python37Packages.audio-metadata
  • python37Packages.bidict
  • python37Packages.flask-socketio
  • python37Packages.google-music
  • python37Packages.google-music-proto
  • python37Packages.google-music-utils
  • python37Packages.python-socketio
  • python37Packages.sortedcollections
  • python37Packages.tbm-utils
  • python38Packages.audio-metadata
  • python38Packages.bidict
  • python38Packages.flask-socketio
  • python38Packages.google-music
  • python38Packages.google-music-proto
  • python38Packages.google-music-utils
  • python38Packages.python-socketio
  • python38Packages.sortedcollections
  • python38Packages.tbm-utils
  • python39Packages.audio-metadata
  • python39Packages.bidict
  • python39Packages.google-music-proto
  • python39Packages.google-music-utils
  • python39Packages.sortedcollections
  • python39Packages.tbm-utils

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108572 run on x86_64-linux 1

29 packages built:
  • appdaemon
  • gdbgui
  • google-music-scripts
  • python37Packages.audio-metadata
  • python37Packages.bidict
  • python37Packages.flask-socketio
  • python37Packages.google-music
  • python37Packages.google-music-proto
  • python37Packages.google-music-utils
  • python37Packages.python-socketio
  • python37Packages.sortedcollections
  • python37Packages.tbm-utils
  • python38Packages.audio-metadata
  • python38Packages.bidict
  • python38Packages.flask-socketio
  • python38Packages.google-music
  • python38Packages.google-music-proto
  • python38Packages.google-music-utils
  • python38Packages.python-socketio
  • python38Packages.sortedcollections
  • python38Packages.tbm-utils
  • python39Packages.audio-metadata
  • python39Packages.bidict
  • python39Packages.flask-socketio
  • python39Packages.google-music-proto
  • python39Packages.google-music-utils
  • python39Packages.python-socketio
  • python39Packages.sortedcollections
  • python39Packages.tbm-utils

@fabaff
Copy link
Member Author

fabaff commented Jan 10, 2021

#108536 was addressing a couple of the same build issues.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108572 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • python39Packages.google-music
26 packages built:
  • appdaemon
  • gdbgui
  • google-music-scripts
  • python37Packages.audio-metadata
  • python37Packages.bidict
  • python37Packages.flask-socketio
  • python37Packages.google-music
  • python37Packages.google-music-proto
  • python37Packages.google-music-utils
  • python37Packages.python-socketio
  • python37Packages.sortedcollections
  • python38Packages.audio-metadata
  • python38Packages.bidict
  • python38Packages.flask-socketio
  • python38Packages.google-music
  • python38Packages.google-music-proto
  • python38Packages.google-music-utils
  • python38Packages.python-socketio
  • python38Packages.sortedcollections
  • python39Packages.audio-metadata
  • python39Packages.bidict
  • python39Packages.flask-socketio
  • python39Packages.google-music-proto
  • python39Packages.google-music-utils
  • python39Packages.python-socketio
  • python39Packages.sortedcollections

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108572 run on x86_64-linux 1

25 packages built:
  • appdaemon
  • gdbgui
  • google-music-scripts
  • python37Packages.audio-metadata
  • python37Packages.bidict
  • python37Packages.flask-socketio
  • python37Packages.google-music
  • python37Packages.google-music-proto
  • python37Packages.google-music-utils
  • python37Packages.python-socketio
  • python37Packages.sortedcollections
  • python38Packages.audio-metadata
  • python38Packages.bidict
  • python38Packages.flask-socketio
  • python38Packages.google-music
  • python38Packages.google-music-proto
  • python38Packages.google-music-utils
  • python38Packages.python-socketio
  • python38Packages.sortedcollections
  • python39Packages.audio-metadata
  • python39Packages.bidict
  • python39Packages.flask-socketio
  • python39Packages.google-music-proto
  • python39Packages.python-socketio
  • python39Packages.sortedcollections

@SuperSandro2000 SuperSandro2000 merged commit 39229a3 into NixOS:master Jan 11, 2021
@fabaff fabaff deleted the bump-sortedcollections branch January 18, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants