Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soundmodem: init at 0.20 #108570

Merged
merged 1 commit into from Jan 6, 2021
Merged

soundmodem: init at 0.20 #108570

merged 1 commit into from Jan 6, 2021

Conversation

ymarkus
Copy link
Contributor

@ymarkus ymarkus commented Jan 6, 2021 •
edited

Motivation for this change

#108545

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ymarkus
Copy link
Contributor Author

ymarkus commented Jan 6, 2021

Thanks for the input. I've changed the two occurrences.
Do you mind explaining what the difference is, please? It builds with both so they must be basically the same, no?

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108570 run on x86_64-linux 1

1 package built:
  • soundmodem

@SuperSandro2000
Copy link
Member

Thanks for the input. I've changed the two occurrences.
Do you mind explaining what the difference is, please? It builds with both so they must be basically the same, no?

pkgconfig is an alias for pkg-config and shadowed in buildPythonPackage. We try to get rid of it slowly that we can remove the alias in the future.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108570 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • soundmodem

@SuperSandro2000 SuperSandro2000 merged commit d0b8b87 into NixOS:master Jan 6, 2021
@ymarkus ymarkus deleted the soundmodem branch January 8, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ymarkus @SuperSandro2000