Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phd2: add GApps wrapper to fix breakage on non-nixos wayland systems #107416

Merged
merged 1 commit into from Jan 5, 2021
Merged

phd2: add GApps wrapper to fix breakage on non-nixos wayland systems #107416

merged 1 commit into from Jan 5, 2021

Conversation

hjones2199
Copy link
Member

@hjones2199 hjones2199 commented Dec 22, 2020 •
edited

Motivation for this change

As a gtk application, phd2 should include wrapGAppsHook as a native build input to prevent breakage on some system configurations.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hjones2199
Copy link
Member Author

Result of nixpkgs-review pr 107416 run on x86_64-linux 1

1 package built:
  • phd2

@symphorien symphorien merged commit f3e84c4 into NixOS:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hjones2199 @symphorien