Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glslang: 8.13.3743 -> 11.1.0 #108526

Merged
merged 1 commit into from Jan 7, 2021
Merged

glslang: 8.13.3743 -> 11.1.0 #108526

merged 1 commit into from Jan 7, 2021

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Jan 5, 2021 •
edited

Motivation for this change
  • update to latest stable
  • versioning scheme change
  • enable on darwin
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak
glslang: 8.13.3743 -> 11.1.0
31bd596 
- versioning scheme change
- enable on darwin
@ofborg ofborg bot requested a review from Ralith January 5, 2021 22:33
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108526 run on x86_64-linux 1

19 packages failed to build and are new build failures:
  • celluloid: log was empty
  • curseradio: log was empty
  • jellyfin-mpv-shim: log was empty
  • jftui: log was empty
  • libplacebo
  • minitube
  • mpc-qt
  • mpv
  • mpv-unwrapped
  • mpvScripts.mpris
  • plex-media-player
  • plex-mpv-shim
  • python37Packages.mpv
  • python38Packages.mpv
  • python39Packages.mpv
  • qimgv
  • somafm-cli
  • sublime-music
  • tuijam
9 packages built:
  • corectrl
  • glslang
  • lutris
  • lutris-free
  • lutris-unwrapped
  • qmplay2
  • vulkan-tools
  • vulkan-tools-lunarg
  • vulkan-validation-layers

mpv fails to build

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108526 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • libplacebo
1 package built:
  • glslang

@SuperSandro2000 SuperSandro2000 merged commit 0565dde into NixOS:master Jan 7, 2021
@prusnak prusnak deleted the glslang branch January 7, 2021 11:02
@primeos
Copy link
Member

primeos commented Jan 7, 2021

@SuperSandro2000 this broke libplacebo and at least mpv. Why was it merged despite the 19 build failures?
See #108723 for more details. I'm not sure yet why this breaks libplacebo though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Awaiting requested review from Ralith

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @SuperSandro2000 @primeos