Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs: 10.23.0 -> 10.23.1, 12.20.0 -> 12.20.1, 14.15.3 -> 14.15.4, 15.5.0 -> 15.5.1 #108542

Merged
merged 4 commits into from Jan 6, 2021
Merged

nodejs: 10.23.0 -> 10.23.1, 12.20.0 -> 12.20.1, 14.15.3 -> 14.15.4, 15.5.0 -> 15.5.1 #108542

merged 4 commits into from Jan 6, 2021

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jan 6, 2021

Motivation for this change

https://nodejs.org/en/blog/vulnerability/january-2021-security-releases/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 6, 2021
@marsam marsam merged commit ee433ea into NixOS:master Jan 6, 2021
@marsam marsam deleted the update-nodejs branch January 6, 2021 03:52
@erictapen
Copy link
Member

@marsam Any suggestions on how to backport this? Should we bump release-20.09 to the latest versions?

I don't see any fixes by upstream ontop of e.g. 10.22.1 and manually patching the mentioned CVEs might get hairy.

@ajs124
Copy link
Member

ajs124 commented Jan 12, 2021

It's probably fine as long as we stay in the same major release. Or do 10.22 and 10.23 have any incompatibilities?

@erictapen
Copy link
Member

Pinging all other nodejs maintainers here. What do you think?

@gilligan @cko @cillianderoiste

@marsam
Copy link
Contributor Author

marsam commented Jan 14, 2021

Sorry for the delay, backported to 20.09 in #109336

@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @erictapen @ajs124