Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.python-engineio: 3.13.2 -> 4.0.0 #108566

Merged
merged 12 commits into from Jan 6, 2021
Merged

python3Packages.python-engineio: 3.13.2 -> 4.0.0 #108566

merged 12 commits into from Jan 6, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 6, 2021

Motivation for this change

Update to latest upstream release

python-enginio: https://github.com/miguelgrinberg/python-engineio/blob/master/CHANGES.md
python-socketio: https://github.com/miguelgrinberg/python-socketio/blob/master/CHANGES.md
flask-socketio: https://github.com/miguelgrinberg/Flask-SocketIO/blob/master/CHANGES.md

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Mic92 January 6, 2021 08:32
@fabaff
Copy link
Member Author

fabaff commented Jan 6, 2021

Result of nixpkgs-review pr 108566 1

11 packages built:
  • appdaemon
  • gdbgui
  • python37Packages.flask-socketio
  • python37Packages.python-engineio
  • python37Packages.python-socketio
  • python38Packages.flask-socketio
  • python38Packages.python-engineio
  • python38Packages.python-socketio
  • python39Packages.flask-socketio
  • python39Packages.python-engineio
  • python39Packages.python-socketio

@Mic92
Copy link
Member

Mic92 commented Jan 6, 2021

Result of nixpkgs-review pr 108566 run on x86_64-linux 1

11 packages built:
  • appdaemon
  • gdbgui
  • python37Packages.flask-socketio
  • python37Packages.python-engineio
  • python37Packages.python-socketio
  • python38Packages.flask-socketio
  • python38Packages.python-engineio
  • python38Packages.python-socketio
  • python39Packages.flask-socketio
  • python39Packages.python-engineio
  • python39Packages.python-socketio

@Mic92 Mic92 merged commit a9a348e into NixOS:master Jan 6, 2021
@fabaff fabaff deleted the python-XXXio branch January 6, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabaff @Mic92