Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] python38Packages.cffi: fix tests #108531

Closed
wants to merge 1 commit into from
Closed

[staging] python38Packages.cffi: fix tests #108531

wants to merge 1 commit into from

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 5, 2021 •
edited

Motivation for this change

follow up to: #108430

returning None is expected behavior when calling ctypes.utils.find_library. Disable tests which assume otherwise.

cc @FRidh

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh January 5, 2021 23:54
@ofborg ofborg bot requested review from domenkozar and LnL7 January 6, 2021 00:03
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.pandas

@jonringer
Copy link
Contributor Author

I was able to build python3Packages.pandas locally

[16:26:29] jon@nixos ~/projects/nixpkgs (fix-py38-cffi)
$ nix build -f . python3Packages.pandas
warning: SQLite database '/nix/var/nix/db/db.sqlite' is busy
[13 built]

@peterhoeg
Copy link
Member

Without this python2Packages.cffi and therefore nixops are both broken.

@FRidh
Copy link
Member

FRidh commented Jan 6, 2021

Without this python2Packages.cffi and therefore nixops are both broken.

#108569

orivej
orivej reviewed Jan 6, 2021
View reviewed changes
pkgs/development/python-modules/cffi/default.nix
py.test -k "not test_char_pointer_conversion"
'';
disabledTests = [
# unix gets mistaken as windows because find_library returns None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test diagnostics could be better, but the fact that find_library('c') returns None and the test falls through to the Windows case indicates that find_library is broken.

orivej
orivej suggested changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@orivej orivej left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python38Packages.cffi tests became broken on staging when #108430 (commited to staging) met with e1ed9b3 (commited to staging-next) in 2f7fa4b. The right fix is to restore the patch for 3.8.6 and remove when updating to 3.8.7.

@jonringer jonringer mentioned this pull request Jan 6, 2021
Closed
10 tasks
@jonringer
Copy link
Contributor Author

alternate pr: #108601

@FRidh
Copy link
Member

FRidh commented Jan 8, 2021

Closing in favor of #108601.

@FRidh FRidh closed this Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej requested changes

@FRidh FRidh Awaiting requested review from FRidh

@domenkozar domenkozar Awaiting requested review from domenkozar

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonringer @peterhoeg @FRidh @orivej