-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[staging] python38Packages.cffi: fix tests #108531
Conversation
@GrahamcOfBorg build python3Packages.pandas |
I was able to build
|
Without this python2Packages.cffi and therefore nixops are both broken. |
|
py.test -k "not test_char_pointer_conversion" | ||
''; | ||
disabledTests = [ | ||
# unix gets mistaken as windows because find_library returns None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test diagnostics could be better, but the fact that find_library('c')
returns None and the test falls through to the Windows case indicates that find_library is broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alternate pr: #108601 |
Closing in favor of #108601. |
Motivation for this change
follow up to: #108430
returning
None
is expected behavior when callingctypes.utils.find_library
. Disable tests which assume otherwise.cc @FRidh
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)