Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

picom: misc fixes #108530

Merged
merged 2 commits into from Jan 6, 2021
Merged

picom: misc fixes #108530

merged 2 commits into from Jan 6, 2021

Conversation

thiagokokada
Copy link
Contributor

@thiagokokada thiagokokada commented Jan 5, 2021 •
edited

Motivation for this change
  • Build option build_docs was renamed to with_docs quite sometime ago: yshui/picom@3f2a671. This means that the manpage were not being build.
  • Remove CFLAG -fno-strict-aliasing that seems to not be used anywhere in the upstream repository. This was probably added for compton a long time ago and never removed, since I can't find the commit that added this.
  • Use release build. This is recommended upstream: https://github.com/yshui/picom#to-build.

Also, add myself as maintainer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
~
❯ nix path-info -S /nix/store/zm67sy1dgccz8iz7gy9vw0s01cj5i2r7-picom-8.2/bin/picom # before
/nix/store/zm67sy1dgccz8iz7gy9vw0s01cj5i2r7-picom-8.2	 156816464

~
❯ nix path-info -S /nix/store/s1m8hars4bzjsidlkkphzycaaq24a46z-picom-8.2/bin/picom # after
/nix/store/s1m8hars4bzjsidlkkphzycaaq24a46z-picom-8.2	 156825808

@thiagokokada
Copy link
Contributor Author

This will probably conflict with this PR: #85490

@thiagokokada
Copy link
Contributor Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 5, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@ofborg ofborg bot requested a review from Enzime January 6, 2021 00:02
@thiagokokada thiagokokada mentioned this pull request Jan 6, 2021
Merged
@thiagokokada
picom: misc fixes
67e2cb0 
- Build option `build_docs` was renamed to `with_docs` quite sometime ago:
  yshui/picom@3f2a671.
  This means that the manpage were not being build.
- Remove CFLAG `-fno-strict-aliasing` seems to not be used anywhere in the
  upstream repository. This was probably added for `compton` a long time
  ago and never removed, since I can't find the commit that added this.
- Use release build. This is recommended upstream:
  https://github.com/yshui/picom#to-build.
@thiagokokada
picom: add thiagokokada as maintainer
5902802
@thiagokokada
Copy link
Contributor Author

Fixed conflict with PR #108555

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108530 run on x86_64-linux 1

1 package built:
  • picom

@SuperSandro2000 SuperSandro2000 merged commit be104bf into NixOS:master Jan 6, 2021
@thiagokokada thiagokokada deleted the picom-misc-fixes branch January 6, 2021 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@Enzime Enzime Awaiting requested review from Enzime

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thiagokokada @SuperSandro2000