Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pytestCheckHook: Add disabledTestFiles option #108529

Merged
merged 2 commits into from Jan 16, 2021
Merged

pythonPackages.pytestCheckHook: Add disabledTestFiles option #108529

merged 2 commits into from Jan 16, 2021

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Jan 5, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
but should probably target staging as this is a commonly used testing hook

@SuperSandro2000
Copy link
Member Author

/rebase-staging

@github-actions github-actions bot changed the base branch from master to staging January 6, 2021 00:13
@jonringer
Copy link
Contributor

@GrahamcOfBorg build python3Packages.pandas

@SuperSandro2000
Copy link
Member Author

ofborg does not want to give me a log...

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python3Packages.pandas

@mweinelt
Copy link
Member

Hey @jonringer @FRidh! As you have both approved of this change, what's keeping it from being merged? Python batch upgrades? If so we should add it to the project.

@jonringer
Copy link
Contributor

I just wanted to verify that there wasn't some edge case which broke some builds, if the pandas build wasn't a false negative, I would have merged a while ago

@jonringer
Copy link
Contributor

was able to build azure-cli locally, pandas got to scipy and i didn't want to finish the build + test

@jonringer jonringer merged commit a93ea0f into NixOS:staging Jan 16, 2021
@SuperSandro2000 SuperSandro2000 deleted the pytest-ignore-file branch January 17, 2021 09:40
@dotlambda
Copy link
Member

This doesn't seem to work with more than one file.

dotlambda
dotlambda reviewed Jan 24, 2021
View reviewed changes
pkgs/development/interpreters/python/hooks/pytest-check-hook.sh
echo "Disabled test file \"$file\" does not exist. Aborting"
exit 1
fi
args+=" --ignore=$file"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems problematic if the filename contains whitespace.

@mweinelt mweinelt mentioned this pull request Jan 24, 2021
Merged
10 tasks
@dotlambda dotlambda mentioned this pull request Jan 24, 2021
Merged
10 tasks
@mweinelt
Copy link
Member

This doesn't seem to work with more than one file.

How does it fail?

@dotlambda
Copy link
Member

How does it fail?

E.g.

Executing pytestCheckPhase
Disabled test file "tests/unit/create/test_creator.py tests/unit/seed/embed/test_bootstrap_link_via_app_data.py" does not exist. Aborting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh FRidh approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: python 8.has: documentation 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SuperSandro2000 @jonringer @mweinelt @dotlambda @FRidh