losslesscut-bin: init at 3.33.1 #108512

ShamrockLee · 2021-01-05T20:19:28Z

Add binary package for

Linux (AppImage)
Mac (dmg, x86_64 version)
Windows (zip)

Motivation for this change

If applied, LosslessCut -- a convenient video editor -- will be available in nixpkgs for Linux, Mac and Windows users.

Things done

Mindavi

Haven't looked too closely to the package definition, but building and running on Linux NixOS works. Cutting out a simple video also works.

I wonder; is there a reason as to not build the electron app from source?

pkgs/applications/video/lossless-cut-bin/linuxbin.nix

ShamrockLee · 2021-01-10T02:29:27Z

Thanks for review and reply.

I wonder; is there a reason as to not build the electron app from source?

It would be wonderful to build from source, and that's what I have tried at first (#91683).

Firstly, I personally have never succeeded in the source-build of any electron project.
They requires development dependencies to work, which means an electron node package will be downloaded and installed by the package manager. The problem is that it always want to download something at build phase as part of the "installation" of the electron package.

Secondly, the author of LosslessCut decided to bundle statically-build ffmpeg and ffprobe libreary instead of relying on the one provided by the package manager ar the environment, and the bundle will be downloaded during installation. We need to hack on the code to make it use the one downloaded by fetchurl or the one linked from the nixpkgs derivation.

It would be great to get some advice on how to build them.

Mindavi · 2021-01-12T16:58:15Z

I understand. I've never built an electron package before, so I can't really give any guidance on that.

IMO this can be merged (I don't have commit rights).

Some MacOS / Windows (not sure if anyone's still on that) testing would be nice.

ShamrockLee · 2021-01-13T19:46:51Z

Just performed some modifications:

Use lib instead of stdenv.lib to fit Deprecate use of stdenv.lib across Nixpkgs #108938.
Bug fix on the source URL for Mac dmg pack. I had forgotten to change the owner name when copy-paste the expression from another work of mine.

nixos-discourse · 2021-03-16T15:56:24Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/480

veprbl

Runs on macOS

pkgs/applications/video/lossless-cut-bin/windows.nix

pkgs/applications/video/lossless-cut-bin/dmg.nix

pkgs/applications/video/lossless-cut-bin/appimage.nix

ShamrockLee · 2021-03-25T14:46:19Z

Rebase onto recent Nixpkgs master and upgrade to 3.33.1

SuperSandro2000 · 2021-03-26T17:03:55Z

No idea if this is a bit overengineered.

veprbl · 2021-03-26T21:12:04Z

No idea if this is a bit overengineered.

I think it could use some refactoring, but I would not say it's terribly complicated.

veprbl

I would suggest to just merge this, but taking pkgs as attribute is not very acceptable.

veprbl · 2021-03-26T21:14:30Z

pkgs/applications/video/lossless-cut-bin/default.nix

@@ -0,0 +1,31 @@
+{ pkgs, stdenvNoCC, lib }:


Suggested change

{ pkgs, stdenvNoCC, lib }:

{ stdenv, callPackage, lib }:

veprbl · 2021-03-26T21:16:22Z

pkgs/applications/video/lossless-cut-bin/default.nix

+    description = "The swiss army knife of lossless video/audio editing";
+    homepage = "https://mifi.no/losslesscut/";
+    license = licenses.mit;
+    maintainers = with maintainers; [ ShamrockLee ];


Suggested change

description = "The swiss army knife of lossless video/audio editing";

homepage = "https://mifi.no/losslesscut/";

license = licenses.mit;

maintainers = with maintainers; [ ShamrockLee ];

description = "The swiss army knife of lossless video/audio editing";

homepage = "https://mifi.no/losslesscut/";

license = licenses.mit;

maintainers = with maintainers; [ ShamrockLee ];

Why not put these into the override below, get rid of callBin

veprbl · 2021-03-26T21:17:18Z

pkgs/applications/video/lossless-cut-bin/default.nix

+    maintainers = with maintainers; [ ShamrockLee ];
+  };
+in (
+  if stdenvNoCC.isDarwin then passthru.dmg


Suggested change

if stdenvNoCC.isDarwin then passthru.dmg

if stdenvNoCC.isDarwin then callPackage ./dmg.nix { inherit version }

and so on

veprbl · 2021-03-26T21:20:07Z

Also, why do you call the package "lossless-cut" if its "losslesscut"

veprbl · 2021-03-26T21:20:46Z

e.g. https://aur.archlinux.org/packages/losslesscut-bin/

ShamrockLee · 2021-03-30T06:48:59Z

Also, why do you call the package "lossless-cut" if its "losslesscut"

It's just because the source repo is named "lossless-cut", and the manual suggests that the attribute be identical to the project name. (or do I misunderstand something?)

losslesscut sounds better, and is also the name of the command to get it start.

Add binary package for * Linux (AppImage) * Mac (dmg, x86_64 version) * Windows (zip) Use lib.meta as per NixOS#108938

ShamrockLee · 2021-03-30T17:40:30Z

Apply the suggestions and rename

Mindavi · 2021-03-30T19:14:17Z

I'd suggest merging this, most or all comments are addressed and it's been open for a long time now. Subsequent updates can incorporate any minor improvements that are needed.

ryneeverett · 2021-04-05T04:44:26Z

Seems like calling the per-platform files in a let-expression makes them impossible to override (AFAIK).

ShamrockLee · 2021-04-09T10:03:52Z

Seems like calling the per-platform files in a let-expression makes them impossible to override (AFAIK).

@ryneeverett Would it be better for the three of them be visible in all-packages.nix or should I put them in the passthru?

ryneeverett · 2021-04-09T17:05:32Z

@ShamrockLee I'm not the person to ask but I would think passthru would be acceptable.

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 5, 2021

ShamrockLee force-pushed the lossless-cut-bin branch 2 times, most recently from ee7308f to 5e21add Compare January 5, 2021 20:48

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 labels Jan 5, 2021

ShamrockLee force-pushed the lossless-cut-bin branch from 5e21add to ac6d0a8 Compare January 5, 2021 21:12

ShamrockLee marked this pull request as ready for review January 6, 2021 15:20

ShamrockLee mentioned this pull request Jan 6, 2021

Packaging requests: lossless-cut #91685

Closed

Mindavi reviewed Jan 9, 2021

View reviewed changes

pkgs/applications/video/lossless-cut-bin/linuxbin.nix Outdated Show resolved Hide resolved

ShamrockLee force-pushed the lossless-cut-bin branch 2 times, most recently from a79fd6e to f756475 Compare January 10, 2021 17:41

ShamrockLee force-pushed the lossless-cut-bin branch from f756475 to 99f1ae6 Compare January 13, 2021 19:39

ShamrockLee mentioned this pull request Mar 16, 2021

[WIP] lossless-cut: Init at version 3.23.7 #91683

Closed

10 tasks

veprbl approved these changes Mar 16, 2021

View reviewed changes

SuperSandro2000 reviewed Mar 18, 2021

View reviewed changes

ShamrockLee force-pushed the lossless-cut-bin branch 2 times, most recently from a176c35 to 69cf681 Compare March 25, 2021 14:45

ShamrockLee requested a review from SuperSandro2000 March 25, 2021 17:32

SuperSandro2000 removed their request for review March 26, 2021 17:03

veprbl reviewed Mar 26, 2021

View reviewed changes

losslesscut-bin: init at 3.33.1

d7cd27d

Add binary package for * Linux (AppImage) * Mac (dmg, x86_64 version) * Windows (zip) Use lib.meta as per NixOS#108938

ShamrockLee force-pushed the lossless-cut-bin branch from 69cf681 to d7cd27d Compare March 30, 2021 17:39

ShamrockLee changed the title ~~lossless-cut-bin: init at 3.30.0~~ losslesscut-bin: init at 3.33.1 Mar 30, 2021

veprbl merged commit 56a4d98 into NixOS:master Apr 18, 2021

ShamrockLee deleted the lossless-cut-bin branch January 11, 2022 17:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

losslesscut-bin: init at 3.33.1 #108512

losslesscut-bin: init at 3.33.1 #108512

ShamrockLee commented Jan 5, 2021 •

edited

Mindavi left a comment •

edited

ShamrockLee commented Jan 10, 2021

Mindavi commented Jan 12, 2021 •

edited

ShamrockLee commented Jan 13, 2021 •

edited

nixos-discourse commented Mar 16, 2021

veprbl left a comment

ShamrockLee commented Mar 25, 2021

SuperSandro2000 commented Mar 26, 2021

veprbl commented Mar 26, 2021

veprbl left a comment

veprbl Mar 26, 2021

veprbl Mar 26, 2021

veprbl Mar 26, 2021

veprbl commented Mar 26, 2021

veprbl commented Mar 26, 2021

ShamrockLee commented Mar 30, 2021

ShamrockLee commented Mar 30, 2021

Mindavi commented Mar 30, 2021

ryneeverett commented Apr 5, 2021

ShamrockLee commented Apr 9, 2021

ryneeverett commented Apr 9, 2021

	if stdenvNoCC.isDarwin then passthru.dmg
	if stdenvNoCC.isDarwin then callPackage ./dmg.nix { inherit version }

losslesscut-bin: init at 3.33.1 #108512

losslesscut-bin: init at 3.33.1 #108512

Conversation

ShamrockLee commented Jan 5, 2021 • edited

Motivation for this change

Things done

Mindavi left a comment • edited

Choose a reason for hiding this comment

ShamrockLee commented Jan 10, 2021

Mindavi commented Jan 12, 2021 • edited

ShamrockLee commented Jan 13, 2021 • edited

nixos-discourse commented Mar 16, 2021

veprbl left a comment

Choose a reason for hiding this comment

ShamrockLee commented Mar 25, 2021

SuperSandro2000 commented Mar 26, 2021

veprbl commented Mar 26, 2021

veprbl left a comment

Choose a reason for hiding this comment

veprbl Mar 26, 2021

Choose a reason for hiding this comment

veprbl Mar 26, 2021

Choose a reason for hiding this comment

veprbl Mar 26, 2021

Choose a reason for hiding this comment

veprbl commented Mar 26, 2021

veprbl commented Mar 26, 2021

ShamrockLee commented Mar 30, 2021

ShamrockLee commented Mar 30, 2021

Mindavi commented Mar 30, 2021

ryneeverett commented Apr 5, 2021

ShamrockLee commented Apr 9, 2021

ryneeverett commented Apr 9, 2021

ShamrockLee commented Jan 5, 2021 •

edited

Mindavi left a comment •

edited

Mindavi commented Jan 12, 2021 •

edited

ShamrockLee commented Jan 13, 2021 •

edited