Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wtype: 2020-09-14 -> 0.3 #108515

Merged
merged 1 commit into from Jan 7, 2021
Merged

wtype: 2020-09-14 -> 0.3 #108515

merged 1 commit into from Jan 7, 2021

Conversation

roosemberth
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from justinlovinger January 5, 2021 21:21
justinlovinger
justinlovinger approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@justinlovinger justinlovinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@roosemberth
wtype: 2020-09-14 -> 0.3
f782b23 
Signed-off-by: Roosembert Palacios <roosemberth@posteo.ch>
@ofborg ofborg bot requested a review from justinlovinger January 6, 2021 15:50
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108515 run on x86_64-linux 1

2 packages built:
  • rofimoji
  • wtype

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

rofimoji:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

@SuperSandro2000 SuperSandro2000 merged commit 400ab9c into NixOS:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@justinlovinger justinlovinger Awaiting requested review from justinlovinger

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roosemberth @SuperSandro2000 @justinlovinger @worldofpeace