Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Town builds unnecessary junctions on highway #8506

Closed
kiwitreekor opened this issue Jan 5, 2021 · 9 comments · Fixed by #8535
Closed

Town builds unnecessary junctions on highway #8506

kiwitreekor opened this issue Jan 5, 2021 · 9 comments · Fixed by #8535
Labels
component: NewGRF This issue is related to NewGRFs enhancement Issue would be a good enhancement; we accept Pull Requests!

Comments

@kiwitreekor
Copy link
Contributor

Version of OpenTTD

1.10.3

Expected result

Towns should not build unnecessary junctions on highway (disallowed construction of houses along roadtype and disabled to be built by towns)

Actual result

image
Towns build unnecessary junctions

Steps to reproduce

  1. Build highway connected with town
  2. Wait until town grows
@Eddi-z
Copy link
Contributor

Eddi-z commented Jan 5, 2021

"Highway" is not a default road in OpenTTD, so you might want to update your "steps to reproduce" by which NewGRFs need to be loaded.

@kiwitreekor
Copy link
Contributor Author

kiwitreekor commented Jan 6, 2021 •
edited

I used Rattroad 1.0.2 to reproduce it, but it is reproducible with any newgrf which includes a roadtype with flag bit 2 set and bit 4 cleared.

@glx22
Copy link
Contributor

glx22 commented Jan 6, 2021

Does it happen for all town layouts ?

@kiwitreekor
Copy link
Contributor Author

image
2x2 layout
image
3x3 layout
image
Default layout

Yes, it happens.

@kiwitreekor
Copy link
Contributor Author

I found that town can build roads after making junctions, I'm not sure whether this is intended or not.
In my opinion, It doesn't seem natural that a city can make a junction on a highway.

2TallTyler added a commit to 2TallTyler/OpenTTD that referenced this issue Jan 8, 2021
@2TallTyler
Fix OpenTTD#8506: Towns don't add junctions to NewGRF roads they cann…
96ba627 
…ot build
@2TallTyler 2TallTyler mentioned this issue Jan 8, 2021
Merged
2TallTyler added a commit to 2TallTyler/OpenTTD that referenced this issue Jan 8, 2021
@2TallTyler
Fix OpenTTD#8506: Towns shouldn't add junctions to NewGRF roads they …
6807bbe 
…cannot build
@glx22
Copy link
Contributor

glx22 commented Jan 8, 2021 •
edited by TrueBrain

@kiwitreekor can you check if #8535 solves the issue ? (A preview is available for this PR): https://preview.openttd.org/pr8535/

@kiwitreekor
Copy link
Contributor Author

#8535 fixes the issue, thanks!

TrueBrain pushed a commit that referenced this issue Jan 9, 2021
@2TallTyler
Fix #8506: Towns shouldn't add junctions to NewGRF roads they cannot …
b045666 
…build (#8535)
TrueBrain added a commit that referenced this issue Jan 9, 2021
@TrueBrain
Revert "Fix #8506: Towns shouldn't add junctions to NewGRF roads they…
78f9213 
… cannot build (#8535)"

This reverts commit b045666.
TrueBrain added a commit that referenced this issue Jan 9, 2021
@TrueBrain
Revert 78f9213: "Fix #8506: Towns shouldn't add junctions to NewGRF r…
fc26f42 
…oads they cannot build (#8535)"

As per #8535 (comment),
jumped the gun here.
TrueBrain added a commit that referenced this issue Jan 9, 2021
@TrueBrain
Revert 78f9213: "Fix #8506: Towns shouldn't add junctions to NewGRF r…
8e6574d 
…oads they cannot build (#8535)" (#8541)

As per #8535 (comment),
jumped the gun here.
@TrueBrain TrueBrain reopened this Jan 9, 2021
@JGRennison
Copy link
Contributor

For reference I added a road/tram type flag in my branch to prevent towns from modifying tiles of a particular road/tram type. JGRennison/OpenTTD-patches@946442a
This is a bit more restrictive than the change proposed in #8535 in that it also covers some other town road operations such as removing free ends.
This sort of mechanism could be an alternative way of solving this.

I had highways (i.e. dual carriageway one way roads of a highway road type) in mind when I added this, but there are no GRFs using this as far as I aware.

2TallTyler added a commit to 2TallTyler/OpenTTD that referenced this issue Feb 24, 2021
@2TallTyler
Fix OpenTTD#8506: Towns don't add junctions to NewGRF roads they cann…
bad9b37 
…ot build
@ldpl ldpl mentioned this issue Oct 15, 2021
Open
@2TallTyler 2TallTyler added component: NewGRF This issue is related to NewGRFs enhancement Issue would be a good enhancement; we accept Pull Requests! labels Oct 19, 2022
@LC-Zorg LC-Zorg mentioned this issue Jan 13, 2023
Closed
@PeterN PeterN mentioned this issue Jan 13, 2023
Merged
@2TallTyler
Copy link
Member

Fixed by #10347.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: NewGRF This issue is related to NewGRFs enhancement Issue would be a good enhancement; we accept Pull Requests!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #8506: Towns shouldn't add junctions to NewGRF roads they cannot build 2TallTyler/OpenTTD
6 participants
@TrueBrain @glx22 @JGRennison @kiwitreekor @Eddi-z @2TallTyler