Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass-git-helper: 1.1.0 -> 1.1.1 #108513

Merged
merged 1 commit into from Jan 16, 2021
Merged

pass-git-helper: 1.1.0 -> 1.1.1 #108513

merged 1 commit into from Jan 16, 2021

Conversation

languitar
Copy link
Contributor

@languitar languitar commented Jan 5, 2021 •
edited

Motivation for this change

I have released a new version upstream of the package. As I don't use nix and have no tools available, I don't know how to compute and updated sha256sum for this. If someone could help, that would be great.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bbjubjub2494
Copy link
Member

Getting this error when building. do you know off-hand if that's a new dependency on your side?

======================================================================
ERROR: test_passgithelper (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: test_passgithelper
Traceback (most recent call last):
  File "/nix/store/papbnjfxwrdkmz6xfp7v2q7nxyvgcr5l-python3-3.8.6/lib/python3.8/unittest/loader.py", lin>
    module = self._get_module_from_name(name)
  File "/nix/store/papbnjfxwrdkmz6xfp7v2q7nxyvgcr5l-python3-3.8.6/lib/python3.8/unittest/loader.py", lin>
    __import__(name)
  File "/build/source/test_passgithelper.py", line 7, in <module>
    from pytest_mock import MockFixture
ModuleNotFoundError: No module named 'pytest_mock'


----------------------------------------------------------------------
Ran 1 test in 0.000s

@bbjubjub2494
Copy link
Member

NVM here's something that builds afaict:
1d3fd9fc6f437bfe7df65145dedfce859884c79c

@SuperSandro2000 SuperSandro2000 changed the title Bump pass-git-helper to 1.1.1 pass-git-helper: 1.1.0 -> 1.1.1 Jan 6, 2021
@languitar
Copy link
Contributor Author

Sorry for the delay and thanks for the help. I have updated the commit.

@ofborg ofborg bot requested a review from vanzef January 8, 2021 09:36
@bbjubjub2494
Copy link
Member

The stdenv.lib refactor caused a merge conflict. Can you rebase or use 973a0d3?

@languitar
pass-git-helper: 1.1.0 -> 1.1.1
15bbb7d 
Bump package and add new test requirements.
@languitar
Copy link
Contributor Author

Rebased

bbjubjub2494
bbjubjub2494 approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@bbjubjub2494 bbjubjub2494 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tested compilation of all pkgs that depend on this change using nixpkgs-review
1 package built:
pass-git-helper
  • Tested execution of all binary files (one)

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/332

@AndersonTorres AndersonTorres merged commit f0e757d into NixOS:master Jan 16, 2021
SuperSandro2000
SuperSandro2000 reviewed Jan 16, 2021
View reviewed changes
pkgs/applications/version-management/git-and-tools/pass-git-helper/default.nix
};

propagatedBuildInputs = [ pyxdg ];
checkInputs = [ pytest ];
checkInputs = [ pytest pytest-mock ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth it to move pytestCheckHook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@bbjubjub2494 bbjubjub2494 bbjubjub2494 approved these changes

@vanzef vanzef Awaiting requested review from vanzef

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@languitar @bbjubjub2494 @nixos-discourse @SuperSandro2000 @AndersonTorres @Janik-Haag