Skip to content

gnome3.gnome-calendar: add GNOME/gnome-calendar#84 #108514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2021
Merged

gnome3.gnome-calendar: add GNOME/gnome-calendar#84 #108514

merged 1 commit into from
Jan 5, 2021
+6 −0

Conversation

worldofpeace
Copy link
Contributor

https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/84

Motivation for this change

cc @jtojnar

I've built this and looked at my calendar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@worldofpeace
gnome3.gnome-calendar: add GNOME/gnome-calendar#84

Verified

This commit was signed with the committer’s verified signature.
jbedo Justin Bedő
GPG key ID: 2C18202C56C182BD
Verified
Learn about vigilant mode
42055a9 
https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/84
@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jan 5, 2021
jtojnar
jtojnar approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♀️

@ofborg ofborg bot requested review from hedning, jtojnar and dasj19 January 5, 2021 20:47
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 5, 2021
@worldofpeace
Copy link
Contributor Author

🤷

seriously the mood 😁

@worldofpeace worldofpeace merged commit d5fb62c into NixOS:master Jan 5, 2021
@worldofpeace worldofpeace deleted the fix-gnome-cal branch January 5, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning

@jtojnar jtojnar

@dasj19 dasj19

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @jtojnar