Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: keeps news about accidents around after vehicle is cleaned up #8497

Merged
merged 1 commit into from Jan 5, 2021

Conversation

TrueBrain
Copy link
Member

Fixes #7611.

Motivation / Problem

Bug-report mentions news not always shown. Investigation shows that this is easily to reproduce with fast-forward, a small airport, and a big plane.

News is kept open in realtime, not game-time. So fastforward makes the problem more obvious.

Description

When a vehicle is cleaned up, all news that points to the news is
also removed. This was a bit evil, as it would also remove any
news related to crashed, acting like the crash never happened.
This left players a bit in the dark what was going on exactly.

Limitations

  • You might not have a clue what vehicle exactly crashed. This is out of scope of the issue and PR.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

When a vehicle is cleaned up, all news that points to the news is
also removed. This was a bit evil, as it would also remove any
news related to crashed, acting like the crash never happened.
This left players a bit in the dark what was going on exactly.
@LordAro
Copy link
Member

LordAro commented Jan 5, 2021

What's still using AddVehicleNewsItem ? Can it be removed entirely?

@TrueBrain
Copy link
Member Author

What's still using AddVehicleNewsItem ? Can it be removed entirely?

Still used, yes. STR_NEWS_FIRST_TRAIN_ARRIVAL etc.

Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message could have #7611 in it, if you feel like squashing

@TrueBrain TrueBrain merged commit dff7ee8 into OpenTTD:master Jan 5, 2021
@TrueBrain TrueBrain deleted the vehicle_disaster branch January 5, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accident/disaster news not always showing
2 participants