Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hdf4] Fix build on Darwin, which blocked gdal, postgis and more #108533

Merged
merged 1 commit into from Jan 8, 2021
Merged

[hdf4] Fix build on Darwin, which blocked gdal, postgis and more #108533

merged 1 commit into from Jan 8, 2021

Conversation

purcell
Copy link
Member

@purcell purcell commented Jan 6, 2021

The libtirpc library is not available on Darwin, which led to hdf4 failing to build and subsequently blocking dependent packages.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@purcell purcell requested a review from knedlsepp January 6, 2021 00:09
@purcell
Copy link
Member Author

purcell commented Jan 6, 2021

Pinging @knedlsepp, who added this dep to fix aarch64 a couple of days ago.

@purcell purcell closed this Jan 6, 2021
@knedlsepp knedlsepp reopened this Jan 6, 2021
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 6, 2021
@knedlsepp
Copy link
Member

@ofborg build hdf4

@knedlsepp
Copy link
Member

Pinging @knedlsepp, who added this dep to fix aarch64 a couple of days ago.

Sorry about that, didn't test for Darwin.

knedlsepp
knedlsepp suggested changes Jan 6, 2021
View reviewed changes
Copy link
Member

@knedlsepp knedlsepp left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine. Could you fix the commit message format to comply to the guidelines

(pkg-name | nixos/<module>): (from -> to | init at version | refactor | etc)

@purcell
hdf4: fix build on darwin
0f4be28 
The fix here is to not include libtirc on Darwin, on which platform
the library is unavailable.
@purcell
Copy link
Member Author

purcell commented Jan 6, 2021

Could you fix the commit message format to comply to the guidelines

Oops, yes, done.

@ofborg ofborg bot requested a review from knedlsepp January 6, 2021 23:05
@purcell
Copy link
Member Author

purcell commented Jan 6, 2021

With the commit message fixed and all the tests clear, I'll go ahead and merge, since the code looks good to you.

@purcell
Copy link
Member Author

purcell commented Jan 6, 2021

Oh, I can't merge it myself, doh. Must not have write access yet, only gained org membership recently.

@knedlsepp
Copy link
Member

Oh, I can't merge it myself, doh. Must not have write access yet, only gained org membership recently.

Same here, otherwise I would have merged.

@purcell
Copy link
Member Author

purcell commented Jan 7, 2021

Maybe the ever-present and helpful @marsam would be kind enough to merge this? :-)

@marsam marsam merged commit ba410c2 into NixOS:master Jan 8, 2021
@purcell
Copy link
Member Author

purcell commented Jan 8, 2021

Yay, thanks @marsam

@purcell purcell deleted the hdf4-darwin-libtirpc branch January 8, 2021 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@knedlsepp knedlsepp Awaiting requested review from knedlsepp

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@purcell @knedlsepp @marsam