Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calls: 0.1.5 -> 0.2.0 with init of callaudiod and feedbackd #107681

Merged
merged 3 commits into from Jan 28, 2021
Merged

calls: 0.1.5 -> 0.2.0 with init of callaudiod and feedbackd #107681

merged 3 commits into from Jan 28, 2021

Conversation

Pacman99
Copy link
Contributor

Motivation for this change

To update calls and add its new dependencies: callaudiod and feedbackd.

The feedbackd package is from @masipcat's #94820, I just bumped the version. I can remove it if that PR gets merged first, but its necessary for this version of calls to build right.

Also callaudiod and feedbackd should probably be setup as modules at some point, possibly as a part of #88767. I might try my hand at it sometime.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from lheckemann and craigem December 27, 2020 02:05
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107681 run on x86_64-linux 1

3 packages built:
  • callaudiod
  • calls
  • feedbackd

@Pacman99 Pacman99 changed the title calls: 0.1.5 -> 0.1.9 with init of callaudiod and feedbackd calls: 0.1.5 -> 0.2.0 with init of callaudiod and feedbackd Jan 21, 2021
@Pacman99
Copy link
Contributor Author

Pacman99 commented Jan 21, 2021 •
edited

Updated calls to 0.2.0 and fixed name and version for feedbackd to match the naming rules. Callaudiod cannot be updated, because calls depends on 0.0.4 this should change in the next calls version.
edit: Also fixed the merge conflict and removed the label

@davidak davidak mentioned this pull request Jan 21, 2021
Closed
@davidak
Copy link
Member

davidak commented Jan 21, 2021

Result of nixpkgs-review pr 107681 1

3 packages built:
  • callaudiod
  • calls
  • feedbackd

davidak
davidak requested changes Jan 21, 2021
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor nitpick

pkgs/applications/audio/callaudiod/default.nix Outdated Show resolved Hide resolved
@davidak
Copy link
Member

davidak commented Jan 21, 2021

Package builds and runs. Cant test the actual functionality.

Screenshot from 2021-01-21 22-18-07

One thing i noticed is that when i close it, the process still runs until i kill it with CTRL+C.

[nix-shell:~/.cache/nixpkgs-review/pr-107681]$ calls

(calls:27003): dbind-WARNING **: 22:18:50.186: Couldn't connect to accessibility bus: Failed to connect to socket /tmp/dbus-GXwHDL6PHu: Connection refused

(sm.puri.Calls:27003): Gtk-CRITICAL **: 22:18:50.276: gtk_application_uninhibit: assertion 'GTK_IS_APPLICATION (application)' failed

^C

davidak
davidak approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pacman99
Copy link
Contributor Author

Pacman99 commented Jan 21, 2021 •
edited

Yeah the description thing makes sense to me, just curious does nixpkgs have any specific guidelines for descriptions? I usually just copy directly from upstream.

One thing i noticed is that when i close it, the process still runs until i kill it with CTRL+C.

I think thats intended, it is supposed to be also be a daemon, so it doesn't kill on application close. Its so it can receive phone calls.

@davidak
Copy link
Member

davidak commented Jan 21, 2021

I usually just copy directly from upstream.

That makes sense most of the time. We have a few simple rules.

https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

Its so it can receive phone calls.

i see. good

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107681 run on x86_64-linux 1

3 packages built:
  • callaudiod
  • calls
  • feedbackd

Pacman99 and others added 3 commits January 27, 2021 11:21
@Pacman99
Copy link
Contributor Author

Updated feedbackd to 2021-01-25

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107681 run on x86_64-linux 1

3 packages built:
  • callaudiod
  • calls
  • feedbackd

@SuperSandro2000 SuperSandro2000 merged commit 3dec079 into NixOS:master Jan 28, 2021
@Pacman99
Copy link
Contributor Author

Thanks for merging!

@masipcat masipcat mentioned this pull request Jan 30, 2021
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@davidak davidak davidak approved these changes

@lheckemann lheckemann Awaiting requested review from lheckemann

@craigem craigem Awaiting requested review from craigem

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pacman99 @SuperSandro2000 @davidak