Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] tremor: fix src link #107678

Closed
wants to merge 1 commit into from
Closed

[20.03] tremor: fix src link #107678

wants to merge 1 commit into from

Conversation

nickfraser
Copy link
Contributor

Motivation for this change

Tremor build broken due to change in URL of the source repo.

Things done

Backported change from master (#90464).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124
Copy link
Member

ajs124 commented Dec 27, 2020

20.03 is EOL

@nickfraser
Copy link
Contributor Author

Apologies, I thought it was still supported, as it doesn't say it's EOL here.

Close this PR if you prefer (and my 3 other ones!)

@SuperSandro2000
Copy link
Member

20.03 is EOL and we no longer accept patches for it. You can backport this to 20.09 if necessary.

@ajs124
Copy link
Member

ajs124 commented Dec 27, 2020

Apologies, I thought it was still supported, as it doesn't say it's EOL here.

Turns out people don't know how to change that #101975 (comment)

@nickfraser
Copy link
Contributor Author

nickfraser commented Dec 27, 2020 •
edited

For anyone else (like myself) who still need to be able build 20.03 packages. You can use my fork. You can add this as a channel (I believe, I haven't actually tested this) as follows:

nix-channel --add https://github.com/nickfraser/nixpkgs/archive/nixos-20.03-small.tar.gz nicksos2003 # NicksOS, get it?

This also applies to #107679, #107680, #107682. I'll accept similar PRs which are required to build certain packages.

@nickfraser nickfraser deleted the release-20.03-tremor-urlfix branch April 15, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+ 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nickfraser @ajs124 @SuperSandro2000 @Janik-Haag @fomichevmi