Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "xwallpaper: remove libseccomp dependency" #107661

Merged
merged 1 commit into from Dec 27, 2020
Merged

Revert "xwallpaper: remove libseccomp dependency" #107661

merged 1 commit into from Dec 27, 2020

Conversation

IvarWithoutBones
Copy link
Member

Motivation for this change

A while ago i removed libseccomp support for xwallpaper due to this issue, this has since gotten fixed. I've reverted that commit, and with that added libseccomp functionality back again.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107661 run on x86_64-linux 1

1 package built:
  • xwallpaper

pniedzwiedzinski
pniedzwiedzinski approved these changes Dec 27, 2020
View reviewed changes
Copy link
Contributor

@pniedzwiedzinski pniedzwiedzinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 works great! <3

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/306

@SuperSandro2000 SuperSandro2000 merged commit 2c7caac into NixOS:master Dec 27, 2020
@IvarWithoutBones IvarWithoutBones deleted the xwallpaper-fix branch December 27, 2020 17:42
@IvarWithoutBones IvarWithoutBones mentioned this pull request Dec 28, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pniedzwiedzinski pniedzwiedzinski pniedzwiedzinski approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@IvarWithoutBones @SuperSandro2000 @nixos-discourse @pniedzwiedzinski