Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datasette: 0.46 -> 0.53 #107651

Merged
merged 1 commit into from Dec 27, 2020
Merged

datasette: 0.46 -> 0.53 #107651

merged 1 commit into from Dec 27, 2020

Conversation

rmcgibbo
Copy link
Contributor

Motivation for this change

Unbreak datasette on hydra (https://hydra.nixos.org/build/133682915) by upgrading to latest release.

Checked that the datasette binary works. Verified license is still correct.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from costrouc December 26, 2020 17:52
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107651 run on x86_64-linux 1

2 packages built:
  • datasette (python38Packages.datasette)
  • python37Packages.datasette

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107651 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • python39Packages.datasette
2 packages built:
  • datasette (python38Packages.datasette)
  • python37Packages.datasette

@SuperSandro2000 SuperSandro2000 merged commit 819561a into NixOS:master Dec 27, 2020
@rmcgibbo rmcgibbo deleted the datasette branch December 27, 2020 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rmcgibbo @SuperSandro2000