New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mathics: init at 1.1.1 #107652
mathics: init at 1.1.1 #107652
Conversation
Result of 1 package built:
|
Besides the package, the NixOS module was also removed in #95505. If it's easy, reverting it could be useful? Not sure if people use the notebook server. |
In this PR I want to add only the package. |
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package built:
|
Result of 1 package failed to build:
Can you disable that test for darwin? |
Added |
done | ||
''; | ||
|
||
disabled = !isPy3k; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disabled = !isPy3k; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is python 3 only software.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See next suggestion.
in | ||
buildPythonApplication rec { | ||
pname = "mathics"; | ||
version = "1.1.1"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version = "1.1.1"; | |
version = "1.1.1"; | |
disabled = !isPy3k; |
SANDBOX=true python mathics/test.py --keep-going | ||
for manage in $(find $out -name manage.py); do | ||
chmod +x $manage | ||
wrapProgram $manage --set PYTHONPATH "$PYTHONPATH:${pythonEnv}/${pythonEnv.sitePackages}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if there is a better way to do this.
Does it build on Darwin now with #108876? If so, is this ready to land (without |
Let's try out. I removed |
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package built:
The following issues got detected with the above build packages.
mathics:
URI literals are deprecated.
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-uri-literals.md |
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package failed to build and are new build failure:
|
This PR is cursed :P The failure is probably fixed by importing this patch: mathics/Mathics@ec5bde2 |
I should probably update this to 2.0.0 anyway, will do it later. |
I marked this as stale due to inactivity. → More info |
I'd love for you to revisit this. I tried to package Mathics 5.0.2 in an overlay, but it crashes on startup with:
final: prev: let
recordclass = prev.python3Packages.buildPythonPackage rec {
pname = "recordclass";
version = "0.18.0.1";
src = prev.python3Packages.fetchPypi {
inherit pname version;
sha256 = "sha256-8HZ6bcWzgRgHTsWv11lt0EpsyZKJT0DuzfS1hzFc5GU=";
};
doCheck = false;
};
mathicsScanner = prev.python3Packages.buildPythonPackage {
pname = "mathics-scanner";
version = "1.2.4";
src = prev.fetchFromGitHub {
owner = "Mathics3";
repo = "mathics-scanner";
rev = "1.2.4";
hash = "sha256-ZdkIvoINbw6MXXOqHy4XKGyOuvDVyWsYufRv2XU+DFg=";
};
propagatedBuildInputs = builtins.attrValues {
inherit (final.python3Packages) chardet click pyyaml;
};
doCheck = false;
};
in {
mathics = let
deps = builtins.attrValues {
inherit (final.python3Packages) dateutil llvmlite numpy palettable pint requests setuptools sympy;
inherit mathicsScanner recordclass;
};
pythonEnv = final.python.withPackages (p: deps);
in prev.python3Packages.buildPythonApplication {
pname = "mathics";
version = "5.0.2";
src = prev.fetchFromGitHub {
owner = "Mathics3";
repo = "mathics-core";
rev = "5.0.2";
hash = "sha256-EnRrI44dD+tYh+RpCzx2q77cU5aoUFi/ETEqQmBxBF0=";
};
propagatedBuildInputs = deps;
doCheck = false;
meta = {
description = "FOSS Mathematica clone";
homepage = "https://mathics.github.io/";
license = prev.lib.licenses.gpl3Only;
};
};
} |
Motivation for this change
Mathics is back. This PR adds mathics at version 1.1.1, released just three days ago.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)