New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KDE Applications: 20.12.0, KDE Frameworks: 5.77, dependencies, patches #107666
KDE Applications: 20.12.0, KDE Frameworks: 5.77, dependencies, patches #107666
Conversation
… fetching source and sha256)
…ives + add some comments and usage info
…txt not finding systemsettings5
…/fix/patch them for 5.15)
What are the advantages of extracting the file hashes from HTML instead of hashing the downloaded files? I want to be sure the additional complexity is justified. |
Basically it's just reduced load on the servers and not having to fetch the files before they're actually needed. And of course it's a way to actually validate the downloaded archive matches what the qt or kde team intended to provide. |
Before this PR becomes a non-Draft, I'll cherry-pick some changes for kinfocenter (it finally works!) from https://github.com/hamburger1984/nixpkgs/commits/kde-plasma-fixes-unstable. |
Regd kinfocenter: #107781 |
Proposed my fixes in that PR. |
Regarding the fetch-kde-qt.sh script:
I'll include the revert and re-generated srcs.nix anyhow as my proposed script doesn't seem to gain too much love here ;-) |
Yes, this is just an encoding issue. The upstream websites undoubtedly list the SHA256 hashes in the conventional hexadecimal (base-16) notation, but all the Nix tools use base-32 (compact, but idiosyncratic). |
Okay. Then my script really would just improve the speed of generating srcs.nix. This does not justify the complexity, as this is not done that often, I guess. @ttuegel any objections towards rebasing this branch on latest staging? |
The upstream fetch-kde-qt.sh was broken for me, so I wrote this: https://gist.github.com/CrystalGamma/c6a7252219b44cf2c6ddaf5e4c49b6da . |
Motivation for this change
Upgraded kde-applications and kde-frameworks to their most recent releases.
Some dependencies added & fixed for kde-applications, kde-frameworks and plasma5.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)