ocamlPackages: init diet, irmin-chunk, mirage-block-combinators, mirage-block-ramdisk, mirage-block-unix, wodan #107667
Conversation
| inherit (wodan) version src useDune2; | ||
|
|
||
| propagatedBuildInputs = [ | ||
| irmin-chunk |
There was a problem hiding this comment.
io-page-unix might be missing here.
There was a problem hiding this comment.
@GrahamcOfBorg build ocamlPackages.wodan-irmin
|
All commits but the last one have been merged ( Unfortunately,
|
| @@ -15,7 +15,8 @@ buildDunePackage rec { | |||
|
|
|||
| minimumOCamlVersion = "4.06"; | |||
|
|
|||
| propagatedBuildInputs = [ cstruct-lwt logs mirage-block rresult uri ]; | |||
| propagatedBuildInputs = | |||
| [ cstruct-lwt io-page-unix logs mirage-block rresult uri ]; | |||
There was a problem hiding this comment.
I don’t understand this change: the mirage-block-unix library does not use io-page-unix in any way, does it?
There was a problem hiding this comment.
Its listed as a dependency, but somehow not used during the checkPhase: https://opam.ocaml.org/packages/mirage-block-unix/
There was a problem hiding this comment.
Does this mean that there is a mistake in the page you’ve linked?
There was a problem hiding this comment.
Well it is listed in the opam and dune metadata of mirage-block-unix.
|
Merged into master as 93e31f2 |
Motivation for this change
I wanted to play around with the
wodancutility and hit some of the dependencies.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)