Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: [Actions] cmakeBuildType is only used with CMakeListsTxtBasic #8435

Merged
merged 1 commit into from Dec 26, 2020
Merged

Fix: [Actions] cmakeBuildType is only used with CMakeListsTxtBasic #8435

merged 1 commit into from Dec 26, 2020

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

Windows nightlies are a debug build, and not the intended release build.

Description

We use CMakeListsTxtAdvanced, and as such, we have to do this our
self via "-DCMAKE_BUILD_TYPE=RelWithDebInfo". Otherwise we are
producing Debug builds instead of Release builds. Oops.

@TrueBrain
Fix: [Actions] cmakeBuildType is only used with CMakeListsTxtBasic
d975312 
We use CMakeListsTxtAdvanced, and as such, we have to do this our
self via "-DCMAKE_BUILD_TYPE=RelWithDebInfo". Otherwise we are
producing Debug builds instead of Release builds. Oops.
@TrueBrain TrueBrain merged commit f2d78b1 into OpenTTD:master Dec 26, 2020
@TrueBrain TrueBrain deleted the release_windows branch December 26, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TrueBrain @LordAro