Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-sdk-cpp: 1.7.90 -> 1.8.113 #107623

Merged
merged 11 commits into from Jan 6, 2021
Merged

aws-sdk-cpp: 1.7.90 -> 1.8.113 #107623

merged 11 commits into from Jan 6, 2021

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Dec 26, 2020

Motivation for this change

Regular update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests): awscli, nix-ssh-serve
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from edolstra December 26, 2020 12:00
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107623 run on x86_64-linux 1

1 package marked as broken and skipped:
  • nix-exec
2 packages blacklisted:
  • tests.nixos-functions.nixos-test
  • tests.nixos-functions.nixosTest-test
2 packages failed to build:
  • python37Packages.nixpkgs
  • python39Packages.nixpkgs
63 packages built:
  • aws-c-cal
  • aws-c-common
  • aws-c-event-stream
  • aws-c-io
  • aws-checksums
  • aws-sdk-cpp
  • bundix
  • cabal2nix
  • cachix
  • common-updater-scripts
  • crate2nix
  • crystal2nix
  • dep2nix
  • disnix
  • disnixos
  • dydisnix
  • fusionInventory
  • go2nix
  • haskellPackages.cachix
  • haskellPackages.hercules-ci-agent
  • haskellPackages.hocker
  • haskellPackages.nix-paths
  • haskellPackages.update-nix-fetchgit
  • hercules-ci-agent
  • hydra-unstable
  • libnixxml
  • lispPackages.quicklisp-to-nix
  • lispPackages.quicklisp-to-nix-system-info
  • nix (nixStable)
  • nix-bundle
  • nix-direnv
  • nix-doc
  • nix-du
  • nix-index
  • nix-pin
  • nix-plugins
  • nix-prefetch
  • nix-prefetch-bzr
  • nix-prefetch-cvs
  • nix-prefetch-docker
  • nix-prefetch-git
  • nix-prefetch-hg
  • nix-prefetch-scripts
  • nix-prefetch-svn
  • nix-serve
  • nix-update
  • nix-update-source
  • nixFlakes (nixUnstable)
  • nixos-generators
  • nixos-shell
  • nixpkgs-review
  • nixui
  • python37Packages.nix-kernel
  • python37Packages.pythonix
  • python38Packages.nix-kernel
  • python38Packages.nixpkgs
  • python38Packages.pythonix
  • python39Packages.nix-kernel
  • python39Packages.pythonix
  • s2n
  • update-nix-fetchgit
  • vgo2nix
  • vulnix

python37Packages.nixpkgs

[pbr] Reusing existing SOURCES.txt
running build_ext
nixpkgs (unittest.loader._FailedTest) ... ERROR

======================================================================
ERROR: nixpkgs (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: nixpkgs
Traceback (most recent call last):
  File "/nix/store/401hv5vy6jm6wyppmlaalakdlsrzchc6-python3-3.7.9/lib/python3.7/unittest/loader.py", line 470, in _find_test_path
    package = self._get_module_from_name(name)
  File "/nix/store/401hv5vy6jm6wyppmlaalakdlsrzchc6-python3-3.7.9/lib/python3.7/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/build/nixpkgs-0.2.4/nixpkgs/__init__.py", line 41, in <module>
    import nix
ModuleNotFoundError: No module named 'nix'


----------------------------------------------------------------------
Ran 1 test in 0.000s

FAILED (errors=1)
Test failed: <unittest.runner.TextTestResult run=1 errors=1 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=1 errors=1 failures=0>

@orivej orivej mentioned this pull request Dec 27, 2020
Closed
@orivej
Copy link
Contributor Author

orivej commented Dec 27, 2020

I have reported the issue about python37Packages.nixpkgs and python39Packages.nixpkgs which happens independently from this PR at Mic92/pythonix#6

@SuperSandro2000 SuperSandro2000 mentioned this pull request Jan 2, 2021
Closed
@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 3, 2021 •
edited

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107623 run on x86_64-linux 1

1 package marked as broken and skipped:
  • nix-exec
2 packages blacklisted:
  • tests.nixos-functions.nixos-test
  • tests.nixos-functions.nixosTest-test
6 packages failed to build and are new build failures:
59 packages built:
  • aws-c-cal
  • aws-c-common
  • aws-c-event-stream
  • aws-c-io
  • aws-checksums
  • aws-sdk-cpp
  • bundix
  • cabal2nix
  • common-updater-scripts
  • crate2nix
  • crystal2nix
  • dep2nix
  • disnix
  • disnixos
  • dydisnix
  • fusionInventory
  • go2nix
  • haskellPackages.hocker
  • haskellPackages.nix-paths
  • haskellPackages.update-nix-fetchgit
  • hydra-unstable
  • libnixxml
  • lispPackages.quicklisp-to-nix
  • lispPackages.quicklisp-to-nix-system-info
  • nix (nixStable)
  • nix-bundle
  • nix-direnv
  • nix-doc
  • nix-du
  • nix-index
  • nix-pin
  • nix-plugins
  • nix-prefetch
  • nix-prefetch-bzr
  • nix-prefetch-cvs
  • nix-prefetch-docker
  • nix-prefetch-git
  • nix-prefetch-hg
  • nix-prefetch-scripts
  • nix-prefetch-svn
  • nix-serve
  • nix-update
  • nix-update-source
  • nixFlakes (nixUnstable)
  • nixos-generators
  • nixos-shell
  • nixpkgs-review
  • nixui
  • python37Packages.nix-kernel
  • python37Packages.pythonix
  • python38Packages.nix-kernel
  • python38Packages.nixpkgs
  • python38Packages.pythonix
  • python39Packages.nix-kernel
  • python39Packages.pythonix
  • s2n
  • update-nix-fetchgit
  • vgo2nix
  • vulnix

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python38Packages.nixpkgs:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

EDIT:

All known build failures which ca be ignored in this PR.

@SuperSandro2000
Copy link
Member

@orivej Can you fix the merge conflict?

@orivej-nixos orivej-nixos merged commit b3ae041 into NixOS:master Jan 6, 2021
@flokli flokli mentioned this pull request Jan 21, 2021
Closed
9 tasks
@flokli
Copy link
Contributor

flokli commented Jan 21, 2021

This broke nix cross compilation: #106759 (comment)

@orivej orivej mentioned this pull request Jan 21, 2021
Merged
10 tasks
@orivej
Copy link
Contributor Author

orivej commented Jan 21, 2021

#110307 should fix it.

@orivej orivej deleted the aws branch March 29, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@orivej @SuperSandro2000 @flokli @orivej-nixos @r-ryantm