Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installation-cd-base.nix: Add 'live.nixos.passwd' boot option #107626

Merged
merged 1 commit into from Jul 3, 2021

Conversation

jakobrs
Copy link
Contributor

@jakobrs jakobrs commented Dec 26, 2020

Motivation for this change

For interactive SSH access to a system without a (working)
keyboard and monitor, without rebuilding the image itself.

Things done

I did nix build -f nixos/release.nix iso_plasma5.x86_64-linux and tried it on real hardware.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stale
Copy link

stale bot commented Jun 26, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 26, 2021
@jakobrs
Copy link
Contributor Author

jakobrs commented Jun 26, 2021

I'm still interested in this. I found this to be very useful when installing NixOS on a system with "difficult" AMD GPU firmware (makes it possible to look in dmesg etc). I have no idea who to ping/request review from but @Mic92 was the last person to touch this file.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 26, 2021
For interactive SSH access to a system without a (working)
keyboard and monitor, without rebuilding the image itself.
Copy link
Member

@Mic92 Mic92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@Mic92 Mic92 merged commit b118976 into NixOS:master Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants