Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yakuake: add missing kwayland dependency #107674

Merged
merged 1 commit into from Dec 27, 2020
Merged

yakuake: add missing kwayland dependency #107674

merged 1 commit into from Dec 27, 2020

Conversation

eliasp
Copy link
Member

@eliasp eliasp commented Dec 26, 2020

The optional dependeny kwayland was missing, CMake complained about it.
It might be helpful once a Wayland Plasma5 session becomes reality.
See also: #100057

Motivation for this change

Ensure all applications are ready with full Wayland support once #100057 is merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • (N/A)) Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eliasp
yakuake: add missing kwayland dependency
a9a3018 
The optional dependeny kwayland was missing, CMake complained about it.
It might be helpful once a Wayland Plasma5 session becomes reality.
See also: NixOS#100057
@eliasp eliasp requested a review from ttuegel as a code owner December 26, 2020 23:00
@ofborg ofborg bot requested a review from FRidh December 26, 2020 23:09
@SuperSandro2000
Copy link
Member

Example log

https://hydra.nixos.org/build/133737456/log

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107674 run on x86_64-linux 1

3 packages built:
  • libsForQt5.yakuake (kdeApplications.yakuake ,libsForQt515.yakuake)
  • libsForQt512.yakuake
  • libsForQt514.yakuake

@Mic92 Mic92 merged commit c7f7583 into NixOS:master Dec 27, 2020
@eliasp eliasp deleted the yakuake-kwayland branch December 27, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eliasp @SuperSandro2000 @Mic92