Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.typesystem: fix on python3.8 and python3.9 #107659

Merged
merged 1 commit into from Feb 8, 2021
Merged

python3Packages.typesystem: fix on python3.8 and python3.9 #107659

merged 1 commit into from Feb 8, 2021

Conversation

rmcgibbo
Copy link
Contributor

Motivation for this change

Fix this package on python3.8 and python3.9. Disabled one test which is failing because of a cosmetic change in python3.8 formatting of regular expression flags, which I also filed as a bug report upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from costrouc December 26, 2020 20:11
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107659 run on x86_64-linux 1

1 package marked as broken and skipped:
  • python39Packages.orm
2 packages failed to build:
  • python37Packages.orm
  • python38Packages.orm
3 packages built:
  • python37Packages.typesystem
  • python38Packages.typesystem
  • python39Packages.typesystem
ERROR: Could not find a version that satisfies the requirement PyMySQL<=0.9.3,>=0.9 (from aiomysql)
ERROR: No matching distribution found for PyMySQL<=0.9.3,>=0.9
cannot build derivation '/nix/store/7r7728fr6pv0yvxg18prw0syj8a5k2q8-python3.8-databases-0.2.6.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/ww60ghmwamkkmby2ndm0gfiq6vj2007p-python3.8-orm-0.1.5.drv': 1 dependencies couldn't be built

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107659 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • python39Packages.orm
2 packages failed to build:
  • python37Packages.orm
  • python38Packages.orm
3 packages built:
  • python37Packages.typesystem
  • python38Packages.typesystem
  • python39Packages.typesystem

@rmcgibbo
Copy link
Contributor Author

rmcgibbo commented Feb 5, 2021

This should be good to go:

Result of nixpkgs-review run on x86_64-linux 1

1 package marked as broken and skipped:
  • python39Packages.orm
5 packages built:
  • python37Packages.orm
  • python37Packages.typesystem
  • python38Packages.orm
  • python38Packages.typesystem
  • python39Packages.typesystem

SuperSandro2000
SuperSandro2000 reviewed Feb 8, 2021
View reviewed changes
pkgs/development/python-modules/typesystem/default.nix
# the default string formatting of regular expression flags which breaks test assertion
"test_to_json_schema_complex_regular_expression"
];
disabledTestFiles = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is finally in master 🎉

@SuperSandro2000

This comment has been minimized.

Sign in to view
1 similar comment
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107659 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • python39Packages.orm
5 packages built:
  • python37Packages.orm
  • python37Packages.typesystem
  • python38Packages.orm
  • python38Packages.typesystem
  • python39Packages.typesystem

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107659 run on x86_64-linux 1

1 package marked as broken and skipped:
  • python39Packages.orm
5 packages built:
  • python37Packages.orm
  • python37Packages.typesystem
  • python38Packages.orm
  • python38Packages.typesystem
  • python39Packages.typesystem

@SuperSandro2000 SuperSandro2000 merged commit 50a96ec into NixOS:master Feb 8, 2021
@rmcgibbo rmcgibbo deleted the typesystem branch February 8, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rmcgibbo @SuperSandro2000