Codechange: Replace FOR_VEHICLE_ORDERS with range-based for loops #8438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Continuing to reduce the number of FOR_XXX macro when it's possible (started in #7864)
Description
Implemented an iterator for
OrderList
insideVehicle
.This iterator is written to support deletion of items during the iteration as
RemoveOrderFromAllVehicles()
can delete orders in the for loop.