Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kermit: use postPatch instead of patchPhase #107683

Merged
merged 1 commit into from Dec 27, 2020
Merged

kermit: use postPatch instead of patchPhase #107683

merged 1 commit into from Dec 27, 2020

Conversation

blitz
Copy link
Contributor

@blitz blitz commented Dec 27, 2020

This is necessary to regain the ability to add patches via overrides.

This is a follow-up from #107658 and addresses a review comment by @SuperSandro2000.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@blitz
kermit: use postPatch instead of patchPhase
a48184d 
This is necessary to regain the ability to add patches via overrides.
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107683 run on x86_64-linux 1

1 package built:
  • kermit

@SuperSandro2000 SuperSandro2000 merged commit ce8a3f7 into NixOS:master Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@pSub pSub Awaiting requested review from pSub

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blitz @SuperSandro2000