Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

credhub-cli: init at 2.9.0 #107454

Merged
merged 1 commit into from Dec 27, 2020
Merged

credhub-cli: init at 2.9.0 #107454

merged 1 commit into from Dec 27, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Dec 23, 2020

Motivation for this change

Add credhub-cli, with most tests enabled. Some tests don't compile with go 1.15 right now, so forcing 1.14.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit December 23, 2020 10:29
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107454 run on x86_64-darwin 1

1 package failed to build:
  • credhub-cli

Many tests fail on darwin. Should probably be disabled on darwin.

Summarizing 402 Failures

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107454 run on x86_64-linux 1

1 package built:
  • credhub-cli

@risicle
Copy link
Contributor Author

risicle commented Dec 23, 2020

Hmm I built it and am successfully using it on macos 10.14 - what errors are you getting?

@SuperSandro2000
Copy link
Member

Hmm I built it and am successfully using it on macos 10.14 - what errors are you getting?

they are probably related to the darwin sandbox which forbids network connections.

@risicle
Copy link
Contributor Author

risicle commented Dec 23, 2020

Well pretty much nothing works for me on this machine with darwin's sandbox enabled, so I can't really test that. I'd rather not disable all the tests on darwin - do the failures give any indication of which tests the failures are in?

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 24, 2020 •
edited

Well pretty much nothing works for me on this machine with darwin's sandbox enabled, so I can't really test that. I'd rather not disable all the tests on darwin - do the failures give any indication of which tests the failures are in?

Yeah it gave but 402 is almost everything so we might just disable all.

Edit:

Ran 402 of 402 Specs in 1.547 seconds

It is everything.

•! Panic in Spec Setup (BeforeEach) [0.001 seconds]
Import [BeforeEach]
code.cloudfoundry.org/credhub-cli/commands_test/import_test.go:10
  when importing an ssh type with key public_key_fingerprint
  code.cloudfoundry.org/credhub-cli/commands_test/import_test.go:187
    when importing yaml
    code.cloudfoundry.org/credhub-cli/commands_test/import_test.go:188
      ignore public_key_fingerprint
      code.cloudfoundry.org/credhub-cli/commands_test/import_test.go:189

      Test Panicked
      httptest: failed to listen on a port: listen tcp6 [::1]:0: bind: operation not permitted
      net/http/httptest/server.go:71

@risicle
Copy link
Contributor Author

risicle commented Dec 24, 2020

This isn't a case where __darwinAllowLocalNetworking would help is it?

@SuperSandro2000
Copy link
Member

This isn't a case where __darwinAllowLocalNetworking would help is it?

It could but you can also just disable the tests.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107454 run on x86_64-darwin 1

1 package built:
  • credhub-cli

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107454 run on x86_64-linux 1

1 package built:
  • credhub-cli

@risicle risicle merged commit 23c1004 into NixOS:master Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @SuperSandro2000