Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libmesode: 0.9.3 -> 0.10.1 #107643

Merged
merged 1 commit into from Dec 28, 2020
Merged

libmesode: 0.9.3 -> 0.10.1 #107643

merged 1 commit into from Dec 28, 2020

Conversation

devhell
Copy link
Contributor

@devhell devhell commented Dec 26, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Dec 26, 2020
View reviewed changes
pkgs/development/libraries/libmesode/default.nix Outdated
sha256 = "140jp7xzskik0sb6aqjsw7z477a124cxl7dkm80m2nyzjng4pzg5";
})
];

nativeBuildInputs = [ autoreconfHook pkgconfig ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nativeBuildInputs = [ autoreconfHook pkgconfig ];
nativeBuildInputs = [ autoreconfHook pkg-config ];

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107643 run on x86_64-darwin 1

2 packages failed to build:
  • libmesode
  • profanity
#define xmpp_vsnprintf vsnprintf
                       ^
/nix/store/r913a0b23i21r8y4x8kgx024gms9lvx9-Libsystem-osx-10.12.6/include/secure/_stdio.h:75:40: note: expanded from macro 'vsnprintf'
  __builtin___vsnprintf_chk (str, len, 0, __darwin_obsz(str), format, ap)
                                       ^
In file included from src/auth.c:21:
src/common.h:287:5: error: expected ')'
src/snprintf.h:29:24: note: expanded from macro 'xmpp_vsnprintf'
#define xmpp_vsnprintf vsnprintf
                       ^
/nix/store/r913a0b23i21r8y4x8kgx024gms9lvx9-Libsystem-osx-10.12.6/include/secure/_stdio.h:75:40: note: expanded from macro 'vsnprintf'
  __builtin___vsnprintf_chk (str, len, 0, __darwin_obsz(str), format, ap)
                                       ^
src/common.h:287:5: note: to match this '('
src/snprintf.h:29:24: note: expanded from macro 'xmpp_vsnprintf'
#define xmpp_vsnprintf vsnprintf
                       ^
/nix/store/r913a0b23i21r8y4x8kgx024gms9lvx9-Libsystem-osx-10.12.6/include/secure/_stdio.h:75:29: note: expanded from macro 'vsnprintf'
  __builtin___vsnprintf_chk (str, len, 0, __darwin_obsz(str), format, ap)
                            ^
In file included from src/auth.c:21:
src/common.h:287:5: error: conflicting types for '__builtin___vsnprintf_chk'
int xmpp_vsnprintf (char *str, size_t count, const char *fmt, va_list arg);
    ^
src/snprintf.h:29:24: note: expanded from macro 'xmpp_vsnprintf'
#define xmpp_vsnprintf vsnprintf
                       ^
/nix/store/r913a0b23i21r8y4x8kgx024gms9lvx9-Libsystem-osx-10.12.6/include/secure/_stdio.h:75:3: note: expanded from macro 'vsnprintf'
  __builtin___vsnprintf_chk (str, len, 0, __darwin_obsz(str), format, ap)
  ^
src/common.h:287:5: note: '__builtin___vsnprintf_chk' is a builtin with type 'int (char *, unsigned long, int, unsigned long, const char *, struct __va_list_tag *)'
src/snprintf.h:29:24: note: expanded from macro 'xmpp_vsnprintf'
#define xmpp_vsnprintf vsnprintf
                       ^
/nix/store/r913a0b23i21r8y4x8kgx024gms9lvx9-Libsystem-osx-10.12.6/include/secure/_stdio.h:75:3: note: expanded from macro 'vsnprintf'
  __builtin___vsnprintf_chk (str, len, 0, __darwin_obsz(str), format, ap)
  ^
6 errors generated.
make: *** [Makefile:1275: src/libmesode_la-auth.lo] Error 1

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107643 run on x86_64-linux 1

2 packages built:
  • libmesode
  • profanity

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

@devhell devhell force-pushed the libmesode branch 2 times, most recently from 69212c0 to f15eff4 Compare December 27, 2020 13:14
devhell
devhell commented Dec 27, 2020
View reviewed changes
Copy link
Contributor Author

@devhell devhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SuperSandro2000, I don't know what to do about it failing on darwin, I don't have a Mac to test this with.

SuperSandro2000
SuperSandro2000 reviewed Dec 27, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just mark it as broken on darwin.

pkgs/development/libraries/libmesode/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107643 run on x86_64-linux 1

2 packages built:
  • libmesode
  • profanity

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107643 run on x86_64-darwin 1

2 packages marked as broken and skipped:
  • libmesode
  • profanity

@SuperSandro2000 SuperSandro2000 merged commit 5568dd4 into NixOS:master Dec 28, 2020
@devhell devhell deleted the libmesode branch December 29, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devhell @SuperSandro2000