Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conduktor: init at 2.15.1 #107642

Merged
merged 2 commits into from Sep 28, 2022
Merged

conduktor: init at 2.15.1 #107642

merged 2 commits into from Sep 28, 2022

Conversation

trobert
Copy link
Contributor

@trobert trobert commented Dec 26, 2020

Motivation for this change

Add conduktor (https://www.conduktor.io/)

Conduktor is a GUI over the Kafka ecosystem, to make the development and management of Apache Kafka clusters as easy as possible.

Free of charge for a single broker.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Dec 26, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the PR title and commit message to conduktor: init at 2.7.2

pkgs/applications/misc/conduktor/default.nix Outdated Show resolved Hide resolved
@trobert trobert changed the title add conduktor conduktor: init at 2.7.2 Dec 27, 2020
@trobert trobert requested a review from roberth May 15, 2021 12:15
@trobert trobert changed the title conduktor: init at 2.7.2 conduktor: init at 2.14.4 May 15, 2021
SuperSandro2000
SuperSandro2000 requested changes May 17, 2021
View reviewed changes
pkgs/applications/misc/conduktor/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/conduktor/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/conduktor/default.nix Outdated Show resolved Hide resolved
SuperSandro2000
SuperSandro2000 requested changes May 25, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also please squash all package related commits.

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/conduktor/default.nix Outdated Show resolved Hide resolved
@trobert trobert force-pushed the conduktor branch 2 times, most recently from 7139f2c to e248825 Compare May 25, 2021 12:05
SuperSandro2000
SuperSandro2000 reviewed May 30, 2021
View reviewed changes
pkgs/applications/misc/conduktor/default.nix
version = "2.14.4";

src = fetchzip {
url = "https://github.com/conduktor/builds/releases/download/v${version}/Conduktor-linux-${version}.zip";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we easily build from source?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not open source

@trobert trobert changed the title conduktor: init at 2.14.4 conduktor: init at 2.15.1 Jun 1, 2021
@stale
Copy link

stale bot commented Jan 9, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 9, 2022
@Congee
Copy link
Contributor

Congee commented Sep 27, 2022

not stale

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 27, 2022
@SuperSandro2000 SuperSandro2000 merged commit 88a2353 into NixOS:master Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberth roberth roberth approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@trobert @Congee @roberth @SuperSandro2000 @bobby285271