Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

canto-daemon: 0.9.7 -> 0.9.8 #107645

Merged
merged 1 commit into from Dec 27, 2020
Merged

canto-daemon: 0.9.7 -> 0.9.8 #107645

merged 1 commit into from Dec 27, 2020

Conversation

devhell
Copy link
Contributor

@devhell devhell commented Dec 26, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107645 run on x86_64-linux 1

2 packages built:
  • canto-curses
  • canto-daemon
254:Ran 0 tests in 0.000s

Please disable tests and add an pythonImportsCheck.

@devhell
Copy link
Contributor Author

devhell commented Dec 27, 2020

Thanks @SuperSandro2000, I've made the changes.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107645 run on x86_64-linux 1

2 packages built:
  • canto-curses
  • canto-daemon

@SuperSandro2000 SuperSandro2000 merged commit 2f47650 into NixOS:master Dec 27, 2020
@devhell devhell deleted the canto-daemon branch December 27, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devhell @SuperSandro2000