New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Airports: Improper aircraft movement when the northernmost airport tile is not part of the layout #8437
Comments
I can't open the save file when downloading from Google Chrome 87, as the browser forces you to delete the file because "it is dangerous" with no way to keep the file. Edit: The above behavior was because I had Safe Browsing on. Affected users may need to disable Safe Browsing for a brief moment in order to download the save game. |
I'd suggest using a different browser if the behaviour can't be disabled. |
… drawn at the wrong height Only the rotated intercontinental airport, don't get excited
Making some progress on this Bug 1 is fixed here - LordAro@b427f30 Bug 2 is proving more tricky. Some notes of things I've found so far:
|
I'm by no means certain of this, but I think this boils down to the "reuse" of The first helipad of the intercontinental has some sort of offset - so the helicopter has to move a bit before loading/unloading, and its The second does not have any offset and it lands directly on the helipad. This means that for some reason that I'm not clear on, the vehicle's This appears to be the case for the majority of helipads (I've not tested them all), it's just that this one for the intercontinental is the exception. This only matters for the (rotated) intercontinental airport due to it being non-rectangular |
From doing a bit of printf debugging, the assignment of the airport tile to the vehicle is here: https://github.com/OpenTTD/OpenTTD/blob/master/src/aircraft_cmd.cpp#L952-L953
The landing altitude in If it's not an oil rig, setting x and y from v->x_pos and v->y_pos and recalculating tile from that looks like it would work.
stops the crash, but I'm not sure whether that's really valid/sensible. |
… drawn at the wrong height Only the rotated intercontinental airport, don't get excited
… drawn at the wrong height Only the rotated intercontinental airport, don't get excited
(Part 2: helicopter landings)
… drawn at the wrong height Only the rotated intercontinental airport, don't get excited
Version of OpenTTD
Current master (2c8c6d4).
Expected result
Aircraft movement is as expected when the northernmost airport tile (lowest tile index corner of the airport layout bounding rectangle) is not part of the airport layout.
Actual result
Aircraft movement is not as expected when the northernmost airport tile (lowest tile index corner of the airport layout bounding rectangle) is not part of the airport layout.
An airport layout with this property is OpenGFX Airports 0.5->Hub->Intercontinental->Rotated 180°.
See attached savegame.
Observed issues include:
Steps to reproduce
See attached savegame.
For sub-issue 1, observe the movement of aircraft 7 and 8.
For sub-issue 2, press the "go" button for aircraft 1 to 6, and observe the subsequent assertion failure when the aircraft next come to land.
Airport Testing Ltd, 2010-02-28.sav.zip
The text was updated successfully, but these errors were encountered: