Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bcachefs: add sha256 kernel module #107613

Merged
merged 1 commit into from Dec 26, 2020
Merged

bcachefs: add sha256 kernel module #107613

merged 1 commit into from Dec 26, 2020

Conversation

davidak
Copy link
Member

@davidak davidak commented Dec 26, 2020

Motivation for this change

needed to mount as root fs

fixes #107571

cc other maintainer @Chiiruno

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@davidak
bcachefs: add sha256 kernel module
d42e2cc 
needed to mount as root fs
Chiiruno
Chiiruno approved these changes Dec 26, 2020
View reviewed changes
Copy link
Contributor

@Chiiruno Chiiruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lovesegfault lovesegfault merged commit c4c899d into NixOS:master Dec 26, 2020
@davidak davidak deleted the bcachefs-sha256 branch December 27, 2020 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chiiruno Chiiruno Chiiruno approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bcachefs: unable to boot from
3 participants
@davidak @Chiiruno @lovesegfault