Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab: take care of vendorSha256 in updater script #107670

Merged
2 commits merged into from Dec 26, 2020
Merged

gitlab: take care of vendorSha256 in updater script #107670

2 commits merged into from Dec 26, 2020

Conversation

ghost
Copy link

@ghost ghost commented Dec 26, 2020 •
edited by ghost

Motivation for this change

Previously the buildGoPackage was used for gitaly, gitlab-workhorse and gitlab-shell, but as per request I changed it to use buildGoModule to save those ten thousand lines of dependency description files and make nixpkgs downloads and evaluations faster.
But when I changed this, I didn't change the update script accordingly, so here are the necessary changes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Milan Pässler added 2 commits December 26, 2020 22:37
gitlab: remove unused deps.nix files
f056f5f 
These were added again in #107558
because the update script still ran vgo2nix.
gitlab: take care of vendorSha256 in updater script
84ff3ce
@ghost ghost changed the title Feature/gitlab update script gitlab: take care of vendorSha256 in updater script Dec 26, 2020
@ghost ghost requested review from flokli, talyz, globin and Mic92 December 26, 2020 21:42
flokli
flokli approved these changes Dec 26, 2020
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner, and nice shortstat :-) Thanks!

@ghost ghost merged commit 44108c5 into NixOS:master Dec 26, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talyz talyz Awaiting requested review from talyz

@globin globin Awaiting requested review from globin

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @SuperSandro2000