vimix-cursors init at 1.0 #107609
vimix-cursors init at 1.0 #107609
Conversation
JorisBlanken
changed the title
|
Please squash the commits together. |
|
You undid some changes with your force push. |
|
Done, bare with me, I'm a noob |
This comment has been minimized.
This comment has been minimized.
|
Result of 1 package built:
|
| cp -pr dist-white $out/share/icons/Vimix-cursors-white | ||
| ''; | ||
|
|
||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
trace: Warning: stdenv.lib is deprecated and will be removed in the next release. Please use lib instead. For more information see #108938
There was a problem hiding this comment.
| meta = with stdenv.lib; { | |
| meta = with lib; { |
| nativeBuildInputs = [ python3Packages.cairosvg xcursorgen ]; | ||
|
|
||
| patches = [ | ||
| (fetchpatch { |
There was a problem hiding this comment.
What is the function of these patches? It might be a good idea to add a comment above each one (https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md)
| cp -pr dist-white $out/share/icons/Vimix-cursors-white | ||
| ''; | ||
|
|
||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
| meta = with stdenv.lib; { | |
| meta = with lib; { |
| @@ -0,0 +1,56 @@ | |||
| { stdenv, fetchFromGitHub, fetchpatch, xcursorgen, python3Packages, bash }: | |||
There was a problem hiding this comment.
| { stdenv, fetchFromGitHub, fetchpatch, xcursorgen, python3Packages, bash }: | |
| { lib, stdenv, fetchFromGitHub, fetchpatch, xcursorgen, python3Packages }: |
| ]; | ||
|
|
||
| buildPhase = '' | ||
| HOME=$TMP ${bash}/bin/bash ./build.sh |
There was a problem hiding this comment.
| HOME=$TMP ${bash}/bin/bash ./build.sh | |
| export HOME=$TMP | |
| bash ./build.sh |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
There was a problem hiding this comment.
@JorisBlanken still interested in getting this Merged? I will close the pr in a few weeks if you aren't
|
There's a new PR for vimix-cursors here: #241054 |
|
Closing this since the author seems inactive. I would suggest @JorisBlanken adds them self as a maintainer of the package in the future if they are interested. Still thank you for your contribution ❤️ |
Motivation for this change
Adds the GTK cursor theme 'Vimix Cursors'. Nixpkgs already provides vimix GTK themes from the same author.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)