Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hakrawler: init at 20201224-e39a514 #107616

Merged
merged 1 commit into from Jan 13, 2021
Merged

hakrawler: init at 20201224-e39a514 #107616

merged 1 commit into from Jan 13, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Dec 26, 2020

Motivation for this change

Add hakrawler (https://github.com/hakluke/hakrawler) a Web crawler for the discovery of endpoints and assets.

Related to #81418

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit December 26, 2020 10:42
@SuperSandro2000 SuperSandro2000 changed the title hakrawler: init 20201224-e39a514 hakrawler: init at 20201224-e39a514 Dec 26, 2020
@SuperSandro2000
Copy link
Member

Please change the commit message to hakrawler: init at 20201224-e39a514.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107616 run on x86_64-linux 1

1 package built:
  • hakrawler

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107616 run on x86_64-darwin 1

1 package built:
  • hakrawler

@fabaff fabaff force-pushed the hakrawler branch 2 times, most recently from 43c31e2 to 6251838 Compare December 28, 2020 08:09
@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000 SuperSandro2000 merged commit 7b596e4 into NixOS:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabaff @SuperSandro2000